You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/22 11:59:19 UTC
[GitHub] [spark] cloud-fan opened a new pull request #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
cloud-fan opened a new pull request #28299:
URL: https://github.com/apache/spark/pull/28299
backport https://github.com/apache/spark/pull/28281 to 2.4
This backport has one difference: there is no `EXTRACT(... FROM ...)` SQL syntax in 2.4, so this PR just uses the common function call syntax.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617862251
**[Test build #121618 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121618/testReport)** for PR 28299 at commit [`13bd834`](https://github.com/apache/spark/commit/13bd8345c9a3487dc28cc1f2c346fe7ea58b6928).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617863087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617737616
**[Test build #121618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121618/testReport)** for PR 28299 at commit [`13bd834`](https://github.com/apache/spark/commit/13bd8345c9a3487dc28cc1f2c346fe7ea58b6928).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617738188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617863087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617738188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617736137
cc @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617890108
Oh, this one seems to out of sync too. I cannot see the merged commit in GitHub branch-2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617891464
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617737616
**[Test build #121618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121618/testReport)** for PR 28299 at commit [`13bd834`](https://github.com/apache/spark/commit/13bd8345c9a3487dc28cc1f2c346fe7ea58b6928).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28299: [SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28299:
URL: https://github.com/apache/spark/pull/28299#issuecomment-617875644
Oops. I'm late. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org