You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by ppadma <gi...@git.apache.org> on 2016/12/08 01:06:26 UTC

[GitHub] drill pull request #676: DRILL-5091: JDBC unit test fail on Java 8

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/676#discussion_r91421952
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java ---
    @@ -477,18 +477,32 @@ public void testClosedConnectionMethodsThrowRight() {
         }
     
         @Override
    +    protected boolean isOkayNonthrowingMethod(Method method) {
    +      // Java 8 method
    +      if ( "getLargeUpdateCount".equals(method.getName())) {
    +        return true; }
    --- End diff --
    
    remove extra space after if ( .  
    } in a separate line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---