You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/04/14 10:30:25 UTC

[superset] branch master updated: fix: Zero values on Dual Line axis bounds (#23649)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new d66e6e6d40 fix: Zero values on Dual Line axis bounds (#23649)
d66e6e6d40 is described below

commit d66e6e6d400db0fee35d73cd43e610cd1c491f4b
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Fri Apr 14 07:30:16 2023 -0300

    fix: Zero values on Dual Line axis bounds (#23649)
---
 superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js
index 727954b2d0..6e2725ad1c 100644
--- a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js
+++ b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js
@@ -844,12 +844,12 @@ function nvd3Vis(element, props) {
       }
 
       chart.yDomain1([
-        yAxisBounds[0] || ticks1[0],
-        yAxisBounds[1] || ticks1[ticks1.length - 1],
+        yAxisBounds[0] ?? ticks1[0],
+        yAxisBounds[1] ?? ticks1[ticks1.length - 1],
       ]);
       chart.yDomain2([
-        yAxis2Bounds[0] || ticks2[0],
-        yAxis2Bounds[1] || ticks2[ticks2.length - 1],
+        yAxis2Bounds[0] ?? ticks2[0],
+        yAxis2Bounds[1] ?? ticks2[ticks2.length - 1],
       ]);
     }