You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Gavin McDonald <gm...@apache.org> on 2015/07/11 20:54:14 UTC
Rat Patch take 2
HI All,
So two issues with the last patch:
1. I missed two pref file for excluding
2. Four files are treated as binaries (.project and .classpath) and so the diff never showed.
I’ve forced the diff in those files so should be good now.
I’ll talk about why those .project and .classpath have mime-types set in the first place in another
thread.
Please find attached a patch to resolve the 6 remaining RAT license issues.
HTH
Gav…
Re: Rat Patch take 2
Posted by jan i <ja...@apache.org>.
Hi Gavin.
I am sorry you are experiencing a delay in getting the patch committed.
I have had a look at the patch, and to me it looks perfect. I would commit
the patch if I could,
but I am currently limited to my ipad (my development system, decided to
take a heat holiday).
I am convinced when one of the others get a couple of spare cycles they
will commit the patch.
Thanks for taking time to make the correction.
rgds
jan i.
On 14 July 2015 at 12:34, Gavin McDonald <gm...@apache.org> wrote:
> Just bumping this, anyone want to apply it?
>
> Thanks
>
> Gav…
>
> > On 11 Jul 2015, at 7:54 pm, Gavin McDonald <gm...@apache.org> wrote:
> >
> >
> > HI All,
> >
> > So two issues with the last patch:
> >
> > 1. I missed two pref file for excluding
> >
> > 2. Four files are treated as binaries (.project and .classpath) and so
> the diff never showed.
> >
> > I’ve forced the diff in those files so should be good now.
> >
> > I’ll talk about why those .project and .classpath have mime-types set in
> the first place in another
> > thread.
> >
> > Please find attached a patch to resolve the 6 remaining RAT license
> issues.
> >
> > HTH
> >
> > Gav…
> >
> >
> > <rat_patch.txt>
>
>
Re: Rat Patch take 2
Posted by Gavin McDonald <ga...@16degrees.com.au>.
rat build run and license issues down to just the two we need to exclude:-
https://ci.apache.org/projects/openoffice/rat-output.html <https://ci.apache.org/projects/openoffice/rat-output.html>
Gav…
> On 14 Jul 2015, at 12:44 pm, Gavin McDonald <ga...@16degrees.com.au> wrote:
>
>
>> On 14 Jul 2015, at 12:37 pm, Regina Henschel <rb...@t-online.de> wrote:
>>
>> Hi Gavin,
>>
>> Gavin McDonald schrieb:
>>> Just bumping this, anyone want to apply it?
>>
>> As far as I see Kay has already done this with
>> http://svn.apache.org/r1690817
>> http://svn.apache.org/r1690818
>> http://svn.apache.org/r1690819
>> http://svn.apache.org/r1690820 <http://svn.apache.org/r1690820>
>
> Ah ok, thanks, the nightly RAT report run hasn’t updated to include these, I’ll force a build.
>
> However, there is one file missed from being committed. At the bottom of the patch is this:
>
> Index: main/rat-excludes
> ===================================================================
> --- main/rat-excludes (revision 1690389)
> +++ main/rat-excludes (working copy)
> @@ -1492,4 +1492,6 @@
>
> main/ooxml/source/framework/OOXMLViewer/.settings/org.eclipse.jdt.core.prefs
> main/ooxml/source/framework/SchemaParser/.settings/org.eclipse.jdt.core.prefs
> +main/ooxml/source/framework/JavaOOXMLParser/.settings/org.eclipse.jdt.core.prefs
> +main/ooxml/source/framework/JavaPartManager/.settings/org.eclipse.jdt.core.prefs
>
>
>
> so the rat-excludes file still needs an update.
>
> Thanks, and thanks Kay for applying the previous patches!
>
> Gav…
>
>>
>> Kind regards
>> Regina
>>
>>
>>>
>>> Thanks
>>>
>>> Gav…
>>>
>>>> On 11 Jul 2015, at 7:54 pm, Gavin McDonald <gm...@apache.org> wrote:
>>>>
>>>>
>>>> HI All,
>>>>
>>>> So two issues with the last patch:
>>>>
>>>> 1. I missed two pref file for excluding
>>>>
>>>> 2. Four files are treated as binaries (.project and .classpath) and so the diff never showed.
>>>>
>>>> I’ve forced the diff in those files so should be good now.
>>>>
>>>> I’ll talk about why those .project and .classpath have mime-types set in the first place in another
>>>> thread.
>>>>
>>>> Please find attached a patch to resolve the 6 remaining RAT license issues.
>>>>
>>>> HTH
>>>>
>>>> Gav…
>>>>
>>>>
>>>> <rat_patch.txt>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>
>
> Gav...
>
> ( ( (
> ( )\ ) )\ ) )\ ) ( ) )
> )\ (()/((()/( (()/( )\ ) ( ) ( /( ( ( ( /( ( ( (
> ((((_)( /(_))/(_)) /(_)) ( (()/( )( ( /( ( )\()))( ))\ ( )\()) ))\ )( ))\
> )\ _ )\ (_)) (_))_| (_)) )\ ) /(_))(()\ )(_)) )\ (_))/(()\ /((_) )\ (_))/ /((_)(()\ /((_)
> (_)_\(_)/ __|| |_ |_ _| _(_/((_) _| ((_)((_)_ ((_)| |_ ((_)(_))( ((_)| |_ (_))( ((_)(_))
> / _ \ \__ \| __| | | | ' \))| _|| '_|/ _` |(_-<| _|| '_|| || |/ _| | _|| || || '_|/ -_)
> /_/ \_\ |___/|_| |___||_||_| |_| |_| \__,_|/__/ \__||_| \_,_|\__| \__| \_,_||_| \___|
>
>
>
>
>
Gav...
( ( (
( )\ ) )\ ) )\ ) ( ) )
)\ (()/((()/( (()/( )\ ) ( ) ( /( ( ( ( /( ( ( (
((((_)( /(_))/(_)) /(_)) ( (()/( )( ( /( ( )\()))( ))\ ( )\()) ))\ )( ))\
)\ _ )\ (_)) (_))_| (_)) )\ ) /(_))(()\ )(_)) )\ (_))/(()\ /((_) )\ (_))/ /((_)(()\ /((_)
(_)_\(_)/ __|| |_ |_ _| _(_/((_) _| ((_)((_)_ ((_)| |_ ((_)(_))( ((_)| |_ (_))( ((_)(_))
/ _ \ \__ \| __| | | | ' \))| _|| '_|/ _` |(_-<| _|| '_|| || |/ _| | _|| || || '_|/ -_)
/_/ \_\ |___/|_| |___||_||_| |_| |_| \__,_|/__/ \__||_| \_,_|\__| \__| \_,_||_| \___|
Re: Rat Patch take 2
Posted by Gavin McDonald <ga...@16degrees.com.au>.
Thanks Regina,
We are all green now! :)
https://ci.apache.org/projects/openoffice/rat-output.html <https://ci.apache.org/projects/openoffice/rat-output.html>
Gav…
> On 14 Jul 2015, at 3:40 pm, Regina Henschel <rb...@t-online.de> wrote:
>
> Hi Gavin,
>
> Gavin McDonald schrieb:
>>
>>> On 14 Jul 2015, at 12:37 pm, Regina Henschel <rb...@t-online.de> wrote:
>>>
>>> Hi Gavin,
>>>
>>> Gavin McDonald schrieb:
>>>> Just bumping this, anyone want to apply it?
>>>
>>> As far as I see Kay has already done this with
>>> http://svn.apache.org/r1690817
>>> http://svn.apache.org/r1690818
>>> http://svn.apache.org/r1690819
>>> http://svn.apache.org/r1690820 <http://svn.apache.org/r1690820>
>>
>> Ah ok, thanks, the nightly RAT report run hasn’t updated to include these, I’ll force a build.
>>
>> However, there is one file missed from being committed. At the bottom of the patch is this:
>>
>> Index: main/rat-excludes
>> ===================================================================
>> --- main/rat-excludes (revision 1690389)
>> +++ main/rat-excludes (working copy)
>> @@ -1492,4 +1492,6 @@
>>
>> main/ooxml/source/framework/OOXMLViewer/.settings/org.eclipse.jdt.core.prefs
>> main/ooxml/source/framework/SchemaParser/.settings/org.eclipse.jdt.core.prefs
>> +main/ooxml/source/framework/JavaOOXMLParser/.settings/org.eclipse.jdt.core.prefs
>> +main/ooxml/source/framework/JavaPartManager/.settings/org.eclipse.jdt.core.prefs
>>
>
> Done with http://svn.apache.org/r1690942
>
> We are happy, that you support us.
>
> Kind regards
> Regina
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
Gav...
( ( (
( )\ ) )\ ) )\ ) ( ) )
)\ (()/((()/( (()/( )\ ) ( ) ( /( ( ( ( /( ( ( (
((((_)( /(_))/(_)) /(_)) ( (()/( )( ( /( ( )\()))( ))\ ( )\()) ))\ )( ))\
)\ _ )\ (_)) (_))_| (_)) )\ ) /(_))(()\ )(_)) )\ (_))/(()\ /((_) )\ (_))/ /((_)(()\ /((_)
(_)_\(_)/ __|| |_ |_ _| _(_/((_) _| ((_)((_)_ ((_)| |_ ((_)(_))( ((_)| |_ (_))( ((_)(_))
/ _ \ \__ \| __| | | | ' \))| _|| '_|/ _` |(_-<| _|| '_|| || |/ _| | _|| || || '_|/ -_)
/_/ \_\ |___/|_| |___||_||_| |_| |_| \__,_|/__/ \__||_| \_,_|\__| \__| \_,_||_| \___|
Re: Rat Patch take 2
Posted by Regina Henschel <rb...@t-online.de>.
Hi Gavin,
Gavin McDonald schrieb:
>
>> On 14 Jul 2015, at 12:37 pm, Regina Henschel <rb...@t-online.de> wrote:
>>
>> Hi Gavin,
>>
>> Gavin McDonald schrieb:
>>> Just bumping this, anyone want to apply it?
>>
>> As far as I see Kay has already done this with
>> http://svn.apache.org/r1690817
>> http://svn.apache.org/r1690818
>> http://svn.apache.org/r1690819
>> http://svn.apache.org/r1690820 <http://svn.apache.org/r1690820>
>
> Ah ok, thanks, the nightly RAT report run hasn’t updated to include these, I’ll force a build.
>
> However, there is one file missed from being committed. At the bottom of the patch is this:
>
> Index: main/rat-excludes
> ===================================================================
> --- main/rat-excludes (revision 1690389)
> +++ main/rat-excludes (working copy)
> @@ -1492,4 +1492,6 @@
>
> main/ooxml/source/framework/OOXMLViewer/.settings/org.eclipse.jdt.core.prefs
> main/ooxml/source/framework/SchemaParser/.settings/org.eclipse.jdt.core.prefs
> +main/ooxml/source/framework/JavaOOXMLParser/.settings/org.eclipse.jdt.core.prefs
> +main/ooxml/source/framework/JavaPartManager/.settings/org.eclipse.jdt.core.prefs
>
Done with http://svn.apache.org/r1690942
We are happy, that you support us.
Kind regards
Regina
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Rat Patch take 2
Posted by Gavin McDonald <ga...@16degrees.com.au>.
> On 14 Jul 2015, at 12:37 pm, Regina Henschel <rb...@t-online.de> wrote:
>
> Hi Gavin,
>
> Gavin McDonald schrieb:
>> Just bumping this, anyone want to apply it?
>
> As far as I see Kay has already done this with
> http://svn.apache.org/r1690817
> http://svn.apache.org/r1690818
> http://svn.apache.org/r1690819
> http://svn.apache.org/r1690820 <http://svn.apache.org/r1690820>
Ah ok, thanks, the nightly RAT report run hasn’t updated to include these, I’ll force a build.
However, there is one file missed from being committed. At the bottom of the patch is this:
Index: main/rat-excludes
===================================================================
--- main/rat-excludes (revision 1690389)
+++ main/rat-excludes (working copy)
@@ -1492,4 +1492,6 @@
main/ooxml/source/framework/OOXMLViewer/.settings/org.eclipse.jdt.core.prefs
main/ooxml/source/framework/SchemaParser/.settings/org.eclipse.jdt.core.prefs
+main/ooxml/source/framework/JavaOOXMLParser/.settings/org.eclipse.jdt.core.prefs
+main/ooxml/source/framework/JavaPartManager/.settings/org.eclipse.jdt.core.prefs
so the rat-excludes file still needs an update.
Thanks, and thanks Kay for applying the previous patches!
Gav…
>
> Kind regards
> Regina
>
>
>>
>> Thanks
>>
>> Gav…
>>
>>> On 11 Jul 2015, at 7:54 pm, Gavin McDonald <gm...@apache.org> wrote:
>>>
>>>
>>> HI All,
>>>
>>> So two issues with the last patch:
>>>
>>> 1. I missed two pref file for excluding
>>>
>>> 2. Four files are treated as binaries (.project and .classpath) and so the diff never showed.
>>>
>>> I’ve forced the diff in those files so should be good now.
>>>
>>> I’ll talk about why those .project and .classpath have mime-types set in the first place in another
>>> thread.
>>>
>>> Please find attached a patch to resolve the 6 remaining RAT license issues.
>>>
>>> HTH
>>>
>>> Gav…
>>>
>>>
>>> <rat_patch.txt>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
Gav...
( ( (
( )\ ) )\ ) )\ ) ( ) )
)\ (()/((()/( (()/( )\ ) ( ) ( /( ( ( ( /( ( ( (
((((_)( /(_))/(_)) /(_)) ( (()/( )( ( /( ( )\()))( ))\ ( )\()) ))\ )( ))\
)\ _ )\ (_)) (_))_| (_)) )\ ) /(_))(()\ )(_)) )\ (_))/(()\ /((_) )\ (_))/ /((_)(()\ /((_)
(_)_\(_)/ __|| |_ |_ _| _(_/((_) _| ((_)((_)_ ((_)| |_ ((_)(_))( ((_)| |_ (_))( ((_)(_))
/ _ \ \__ \| __| | | | ' \))| _|| '_|/ _` |(_-<| _|| '_|| || |/ _| | _|| || || '_|/ -_)
/_/ \_\ |___/|_| |___||_||_| |_| |_| \__,_|/__/ \__||_| \_,_|\__| \__| \_,_||_| \___|
Re: Rat Patch take 2
Posted by Regina Henschel <rb...@t-online.de>.
Hi Gavin,
Gavin McDonald schrieb:
> Just bumping this, anyone want to apply it?
As far as I see Kay has already done this with
http://svn.apache.org/r1690817
http://svn.apache.org/r1690818
http://svn.apache.org/r1690819
http://svn.apache.org/r1690820
Kind regards
Regina
>
> Thanks
>
> Gav…
>
>> On 11 Jul 2015, at 7:54 pm, Gavin McDonald <gm...@apache.org> wrote:
>>
>>
>> HI All,
>>
>> So two issues with the last patch:
>>
>> 1. I missed two pref file for excluding
>>
>> 2. Four files are treated as binaries (.project and .classpath) and so the diff never showed.
>>
>> I’ve forced the diff in those files so should be good now.
>>
>> I’ll talk about why those .project and .classpath have mime-types set in the first place in another
>> thread.
>>
>> Please find attached a patch to resolve the 6 remaining RAT license issues.
>>
>> HTH
>>
>> Gav…
>>
>>
>> <rat_patch.txt>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Rat Patch take 2
Posted by Gavin McDonald <gm...@apache.org>.
Just bumping this, anyone want to apply it?
Thanks
Gav…
> On 11 Jul 2015, at 7:54 pm, Gavin McDonald <gm...@apache.org> wrote:
>
>
> HI All,
>
> So two issues with the last patch:
>
> 1. I missed two pref file for excluding
>
> 2. Four files are treated as binaries (.project and .classpath) and so the diff never showed.
>
> I’ve forced the diff in those files so should be good now.
>
> I’ll talk about why those .project and .classpath have mime-types set in the first place in another
> thread.
>
> Please find attached a patch to resolve the 6 remaining RAT license issues.
>
> HTH
>
> Gav…
>
>
> <rat_patch.txt>