You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2015/08/14 22:40:15 UTC
[26/50] [abbrv] incubator-geode git commit: Fix GEODE-154: HDFS
region with HeapLRU reports LowMemoryExceptions even when region size is less
then the eviction threshold
Fix GEODE-154: HDFS region with HeapLRU reports LowMemoryExceptions
even when region size is less then the eviction threshold
- calling setUsageThreshold() on MemoryPoolMXBean resulted in
it reporting incorrect memory usage causing temporary spikes.
Since we already set CollectionThreshold at 1 byte and also have a
stat and heap poller thread, we now skip setting the usage threshold.
Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/c575983f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/c575983f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/c575983f
Branch: refs/heads/feature/GEODE-77
Commit: c575983f14c5417cd631f0d144f514d4c6cf79c1
Parents: ea9f03e
Author: Namrata Thanvi <nt...@pivotal.io>
Authored: Thu Aug 6 14:22:53 2015 +0530
Committer: Namrata Thanvi <nt...@pivotal.io>
Committed: Thu Aug 6 14:22:53 2015 +0530
----------------------------------------------------------------------
.../internal/cache/control/HeapMemoryMonitor.java | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/c575983f/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
----------------------------------------------------------------------
diff --git a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
index 8346245..fda337b 100644
--- a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
+++ b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
@@ -554,18 +554,7 @@ public void stopMonitoring() {
* Number of bytes of heap memory currently used.
*/
private void setUsageThresholdOnMXBean(final long bytesUsed) {
- if (testDisableMemoryUpdates) {
- return;
- }
-
- final MemoryPoolMXBean memoryPoolMXBean = getTenuredMemoryPoolMXBean();
- final MemoryThresholds saveThresholds = this.thresholds;
-
- if (bytesUsed < saveThresholds.getEvictionThresholdBytes()) {
- memoryPoolMXBean.setUsageThreshold(saveThresholds.getEvictionThresholdBytes());
- } else {
- memoryPoolMXBean.setUsageThreshold(saveThresholds.getCriticalThresholdBytes());
- }
+ //// this method has been made a no-op to fix bug 49064
}
/**