Re: [Apache Bloodhound] #764: Global commands should be filtered from product-scope help, and product-scope commands filtered from global help

[Apache Bloodhound <de...@bloodhound.apache.org>]

#764: Global commands should be filtered from product-scope help, and product-
scope commands filtered from global help
---------------------------+---------------------------
  Reporter:  rjollos       |      Owner:  olemis
      Type:  defect        |     Status:  assigned
  Priority:  major         |  Milestone:
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  product admin
---------------------------+---------------------------
Changes (by olemis):

 * owner:  nobody => olemis
 * status:  new => assigned


Comment:

 Replying to [ticket:764 rjollos]:
 > After applying the patches in #757, the following commands are defined
 as global:
 > {{{#!python
 > GLOBAL_COMMANDS = ('deploy', 'hotcopy', 'initenv', 'upgrade')
 > }}}
 >
 > Therefore, when running `trac-admin $env product admin $prod help`, I'd
 expect these command to not be contained in the output, however they are.
 >

 +1

 > When running `trac-admin $env help`, I'd expect the product-scope
 commands such as `version add` to not be contained in the output, however
 they are.
 >

 I do not agree on this one . The global product environment can own other
 resources as well as product environments .

 > A diff of the output between global-scoped help and product-scoped help
 is:
 > {{{#!diff
 > --- global_help       2014-02-24 11:59:31.742002598 -0800
 > +++ product_help      2014-02-24 11:59:18.853612315 -0800
 > @@ -1,9 +1,4 @@
 >  trac-admin - The Trac Administration Console 1.0.1
 > -
 > -Usage: trac-admin </path/to/projenv> [command [subcommand] [option
 ...]]
 > -
 > -Invoking trac-admin without command starts interactive mode.
 > -
 >  help                 Show documentation
 >  initenv              Create and initialize a new environment
 >  attachment add       Attach a file to a resource
 > @@ -42,12 +37,6 @@
 >  priority list        Show possible ticket priorities
 >  priority order       Move a priority value up or down in the list
 >  priority remove      Remove a priority value
 > -product add          Add a new product
 > -product admin        Execute admin (sub-)command upon product resources
 > -product chown        Change product ownership
 > -product list         Show available products
 > -product remove       Remove/uninstall a product
 > -product rename       Rename a product
 >  repository add       Add a source repository
 >  repository alias     Create an alias for a repository
 >  repository list      List source repositories
 > }}}
 >

 Yes , product commands are not available in product context , only global
 .

 > Finally, as can be seen from the diff, the first few lines of output of
 the global help command are:
 > {{{#!sh
 > trac-admin - The Trac Administration Console 1.0.1
 >
 > Usage: trac-admin </path/to/projenv> [command [subcommand] [option ...]]
 >
 > Invoking trac-admin without command starts interactive mode.
 >
 > help                 Show documentation
 > }}}
 >
 > The first few lines of output of the product-scope help command are:
 > {{{#!sh
 > trac-admin - The Trac Administration Console 1.0.1
 > help                 Show documentation
 > }}}
 >
 > For the latter, I'd expect the output to be:
 > {{{#!sh
 > trac-admin - The Trac Administration Console 1.0.1
 >
 > Usage: trac-admin </path/to/projenv> product admin <product id> [command
 [subcommand] [option ...]]
 >
 > Invoking trac-admin without command starts interactive mode.
 >
 > help                 Show documentation
 > }}}
 >

 +1

 [...]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/764#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker