You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:09:21 UTC

[GitHub] [spark] beliefer edited a comment on pull request #33889: [SPARK-36632][SQL] DivideYMInterval should consider ansi mode.

beliefer edited a comment on pull request #33889:
URL: https://github.com/apache/spark/pull/33889#issuecomment-911424584


   @MaxGekk 
   `DivideYMInterval` not consider the ansi mode, which leads some issue:
   
   - `Divide` supports both ansi and non-ansi mode. `DivideYMInterval` only supports ansi mode. If `DivideYMInterval` does not need to support non-ansi mode, then it is very contradictory with the second issue.
   
   - If we use `Divide` with non-ansi mode, when `Analyzer` replacing `Divide` with `DivideYMInterval`, current code ignored the non-ansi mode . The behavior looks so strange.
   
   Or I think, if ansi interval encounters a `failOnError`, it should throw an unsupported exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org