You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2024/04/10 00:27:04 UTC
[I] [C++]: Unused parameter warnings when compiling from nanoarrow [arrow]
WillAyd opened a new issue, #41112:
URL: https://github.com/apache/arrow/issues/41112
### Describe the bug, including details regarding any error messages, version, and platform.
Excerpt from the nanoarrow build:
```sh
[4/10] Compiling C++ object src/nanoarrow/array_test.p/array_test.cc.o
FAILED: src/nanoarrow/array_test.p/array_test.cc.o
c++ -Isrc/nanoarrow/array_test.p -Isrc/nanoarrow -I../src/nanoarrow -Isrc -I../src -I/home/arrow-nanoarrow/arrow/include -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O3 -pthread -isystem../subprojects/googletest-1.14.0/googletest -isystemsubprojects/googletest-1.14.0/googletest -isystem../subprojects/googletest-1.14.0/googletest/include -MD -MQ src/nanoarrow/array_test.p/array_test.cc.o -MF src/nanoarrow/array_test.p/array_test.cc.o.d -o src/nanoarrow/array_test.p/array_test.cc.o -c ../src/nanoarrow/array_test.cc
In file included from /home/arrow-nanoarrow/arrow/include/arrow/buffer.h:29,
from /home/arrow-nanoarrow/arrow/include/arrow/array/data.h:27,
from /home/arrow-nanoarrow/arrow/include/arrow/array/array_base.h:26,
from /home/arrow-nanoarrow/arrow/include/arrow/array.h:41,
from ../src/nanoarrow/array_test.cc:21:
/home/arrow-nanoarrow/arrow/include/arrow/device.h: In member function ‘virtual arrow::Result<std::shared_ptr<arrow::Device::Stream> > arrow::Device::MakeStream(unsigned int)’:
/home/arrow-nanoarrow/arrow/include/arrow/device.h:142:67: error: unused parameter ‘flags’ [-Werror=unused-parameter]
142 | virtual Result<std::shared_ptr<Stream>> MakeStream(unsigned int flags) {
| ~~~~~~~~~~~~~^~~~~
/home/arrow-nanoarrow/arrow/include/arrow/device.h: In member function ‘virtual arrow::Result<std::shared_ptr<arrow::Device::Stream> > arrow::Device::WrapStream(void*, arrow::Device::Stream::release_fn_t)’:
/home/arrow-nanoarrow/arrow/include/arrow/device.h:152:60: error: unused parameter ‘device_stream’ [-Werror=unused-parameter]
152 | virtual Result<std::shared_ptr<Stream>> WrapStream(void* device_stream,
| ~~~~~~^~~~~~~~~~~~~
/home/arrow-nanoarrow/arrow/include/arrow/device.h:153:75: error: unused parameter ‘release_fn’ [-Werror=unused-parameter]
153 | Stream::release_fn_t release_fn) {
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
In file included from /home/arrow-nanoarrow/arrow/include/arrow/array/data.h:29,
from /home/arrow-nanoarrow/arrow/include/arrow/array/array_base.h:26,
from /home/arrow-nanoarrow/arrow/include/arrow/array.h:41,
from ../src/nanoarrow/array_test.cc:21:
/home/arrow-nanoarrow/arrow/include/arrow/type.h: In member function ‘virtual std::string arrow::MonthIntervalType::ToString(bool) const’:
/home/arrow-nanoarrow/arrow/include/arrow/type.h:1726:29: error: unused parameter ‘show_metadata’ [-Werror=unused-parameter]
1726 | std::string ToString(bool show_metadata = false) const override { return name(); }
| ~~~~~^~~~~~~~~~~~~~~~~~~~~
/home/arrow-nanoarrow/arrow/include/arrow/type.h: In member function ‘virtual std::string arrow::DayTimeIntervalType::ToString(bool) const’:
/home/arrow-nanoarrow/arrow/include/arrow/type.h:1762:29: error: unused parameter ‘show_metadata’ [-Werror=unused-parameter]
1762 | std::string ToString(bool show_metadata = false) const override { return name(); }
| ~~~~~^~~~~~~~~~~~~~~~~~~~~
/home/arrow-nanoarrow/arrow/include/arrow/type.h: In member function ‘virtual std::string arrow::MonthDayNanoIntervalType::ToString(bool) const’:
/home/arrow-nanoarrow/arrow/include/arrow/type.h:1802:29: error: unused parameter ‘show_metadata’ [-Werror=unused-parameter]
1802 | std::string ToString(bool show_metadata = false) const override { return name(); }
| ~~~~~^~~~~~~~~~~~~~~~~~~~~
In file included from /home/arrow-nanoarrow/arrow/include/arrow/array/builder_binary.h:33,
from ../src/nanoarrow/array_test.cc:22:
/home/arrow-nanoarrow/arrow/include/arrow/array/builder_base.h: In member function ‘virtual arrow::Status arrow::ArrayBuilder::AppendArraySlice(const arrow::ArraySpan&, int64_t, int64_t)’:
/home/arrow-nanoarrow/arrow/include/arrow/array/builder_base.h:178:52: error: unused parameter ‘array’ [-Werror=unused-parameter]
178 | virtual Status AppendArraySlice(const ArraySpan& array, int64_t offset,
| ~~~~~~~~~~~~~~~~~^~~~~
/home/arrow-nanoarrow/arrow/include/arrow/array/builder_base.h:178:67: error: unused parameter ‘offset’ [-Werror=unused-parameter]
178 | virtual Status AppendArraySlice(const ArraySpan& array, int64_t offset,
| ~~~~~~~~^~~~~~
/home/arrow-nanoarrow/arrow/include/arrow/array/builder_base.h:179:43: error: unused parameter ‘length’ [-Werror=unused-parameter]
179 | int64_t length) {
```
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Unused parameter warnings when compiling from nanoarrow [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #41112:
URL: https://github.com/apache/arrow/issues/41112#issuecomment-2064703363
Issue resolved by pull request 41111
https://github.com/apache/arrow/pull/41111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Unused parameter warnings when compiling from nanoarrow [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv closed issue #41112: [C++] Unused parameter warnings when compiling from nanoarrow
URL: https://github.com/apache/arrow/issues/41112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org