[jira] [Comment Edited] (HBASE-14462) rolling_restart.sh --master-only throws "line 142: test: 0: unary operator expected"

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030310#comment-15030310 ] 

Ted Yu edited comment on HBASE-14462 at 11/27/15 11:28 PM:
-----------------------------------------------------------

Looks good overall.
{code}
+    ret=$?
     echo -n "Waiting for ${zunassigned} to empty"
     while true ; do
+      if test 0 -eq ${ret}
+      then
{code}
The $\{ret\} is only used once, right ?
Consider lifting the check out of while loop.


was (Author: yuzhihong@gmail.com):
Looks good overall.
{code}
+    ret=$?
     echo -n "Waiting for ${zunassigned} to empty"
     while true ; do
+      if test 0 -eq ${ret}
+      then
{code}
The \$\{ret\} is only used once, right ?
Consider lifting the check out of while loop.

> rolling_restart.sh --master-only throws "line 142: test: 0: unary operator expected"
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-14462
>                 URL: https://issues.apache.org/jira/browse/HBASE-14462
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14462.patch, HBASE-14462.patch
>
>
> I was trying to run this on distributed cluster (master branch build) and ended up with this error. Looking in to this,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)