[jira] [Commented] (KAFKA-1866) LogStartOffset gauge throws exceptions after log.delete()

["Sriharsha Chintalapani (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315682#comment-14315682 ] 

Sriharsha Chintalapani commented on KAFKA-1866:
-----------------------------------------------

Updated reviewboard https://reviews.apache.org/r/30084/diff/
 against branch origin/trunk

> LogStartOffset gauge throws exceptions after log.delete()
> ---------------------------------------------------------
>
>                 Key: KAFKA-1866
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1866
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gian Merlino
>            Assignee: Sriharsha Chintalapani
>         Attachments: KAFKA-1866.patch, KAFKA-1866_2015-02-10_22:50:09.patch
>
>
> The LogStartOffset gauge does "logSegments.head.baseOffset", which throws NoSuchElementException on an empty list, which can occur after a delete() of the log. This makes life harder for custom MetricsReporters, since they have to deal with .value() possibly throwing an exception.
> Locally we're dealing with this by having Log.delete() also call removeMetric on all the gauges. That also has the benefit of not having a bunch of metrics floating around for logs that the broker is not actually handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)