You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/23 05:04:00 UTC
[PR] test(frontend): extend DownloadService coverage; fix jszip default import [texera]
aglinxinyuan opened a new pull request, #6817:
URL: https://github.com/apache/texera/pull/6817
### What changes were proposed in this PR?
Extends `download.service.spec.ts` with 4 tests (19 -> 23) and un-skips the previously-skipped zip tests, reaching 100% coverage of `download.service.ts`. New/strengthened tests cover the multi-file operators-result zip branch (loads the produced blob back and asserts entries), the `flat()` merge routing, `createWorkflowsZip` assembly (one JSON per workflow), `nameWorkflow` collision de-duplication, and the `exportWorkflowResultToLocal` empty-token fallback.
**Source change:** `import * as JSZip` -> `import JSZip from "jszip"` in `download.service.ts`. The namespace import makes `new JSZip()` throw "not a constructor" under esbuild/Vitest (and esbuild warns it will crash at runtime), which had forced every zip path to be skipped. The default import matches the existing usage in `user-workflow.component.ts` (already shipped in the prod build) and is safe for the webpack prod build — jszip is CommonJS (`module.exports = JSZip`) and `allowSyntheticDefaultImports` is set.
### Any related issues, documentation, discussions?
Closes #6813.
### How was this PR tested?
`ng test --include='**/download.service.spec.ts'` -> 23/23 passing (0 skipped). `yarn format:ci` passes. The default-import pattern is already used and shipped in `user-workflow.component.ts`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): extend DownloadService coverage; fix jszip default import [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #6817:
URL: https://github.com/apache/texera/pull/6817#issuecomment-5054767287
Closing as it doesn't increase coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): extend DownloadService coverage; fix jszip default import [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #6817:
URL: https://github.com/apache/texera/pull/6817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): extend DownloadService coverage; fix jszip default import [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed pull request #6817: test(frontend): extend DownloadService coverage; fix jszip default import
URL: https://github.com/apache/texera/pull/6817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): extend DownloadService coverage; fix jszip default import [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6817:
URL: https://github.com/apache/texera/pull/6817#issuecomment-5054746720
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6817?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.27%. Comparing base ([`110a54c`](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f36e41c`](https://app.codecov.io/gh/apache/texera/commit/f36e41c8e09f1a1efb121275f7c0cef9bb687b1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6817 +/- ##
=========================================
Coverage 76.27% 76.27%
Complexity 3452 3452
=========================================
Files 1161 1161
Lines 45919 45919
Branches 5100 5100
=========================================
Hits 35025 35025
Misses 9329 9329
Partials 1565 1565
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.33% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.21% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.71% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.15% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6817/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [110a54c](https://app.codecov.io/gh/apache/texera/commit/110a54c151dc692a0720235f3951c41e60ec363a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6817?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(frontend): extend DownloadService coverage; fix jszip default import [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6817:
URL: https://github.com/apache/texera/pull/6817#issuecomment-5054655901
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@mengw15`, `@gracecluvohio`
You can notify them by mentioning `@mengw15`, `@gracecluvohio` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org