You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2015/05/27 21:42:21 UTC
Review Request 34731: Fix vague blueprint configuration processor
message to include the property name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34731/
-----------------------------------------------------------
Review request for Ambari and Robert Nettleton.
Bugs: AMBARI-11441
https://issues.apache.org/jira/browse/AMBARI-11441
Repository: ambari
Description
-------
If the blueprint configuration processor is unable to properly resolve the provided configuration an exception is thrown that is vague and doesn't include the offending property name.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java a84bf3d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 595cc4a
Diff: https://reviews.apache.org/r/34731/diff/
Testing
-------
Functional Testing:
Provisioned clusters via blueprint
Unit Testing:
- new unit test
- currently running existing unit tests and will update review prior to merging
Thanks,
John Speidel
Re: Review Request 34731: Fix vague blueprint configuration processor
message to include the property name
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34731/#review85427
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 27, 2015, 7:42 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34731/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 7:42 p.m.)
>
>
> Review request for Ambari and Robert Nettleton.
>
>
> Bugs: AMBARI-11441
> https://issues.apache.org/jira/browse/AMBARI-11441
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If the blueprint configuration processor is unable to properly resolve the provided configuration an exception is thrown that is vague and doesn't include the offending property name.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java a84bf3d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 595cc4a
>
> Diff: https://reviews.apache.org/r/34731/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> Provisioned clusters via blueprint
>
> Unit Testing:
> - new unit test
> - currently running existing unit tests and will update review prior to merging
>
>
> Thanks,
>
> John Speidel
>
>