You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/04 15:08:44 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #22561: Support Timestamp type in xlang JDBC Read and Write

Abacn commented on code in PR #22561:
URL: https://github.com/apache/beam/pull/22561#discussion_r937910166


##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -647,9 +648,36 @@ def _from_typing(cls, typ):
                                     ('micros', np.int64)])
 
 
+@LogicalType.register_logical_type
+class DateTimeLogicalType(NoArgumentLogicalType[Timestamp, np.int64]):

Review Comment:
   You are right. removed this class the test still pass and confirmed with database content. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org