You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jordan West (Jira)" <ji...@apache.org> on 2020/10/16 03:55:00 UTC

[jira] [Commented] (CASSANDRA-16048) Safely Ignore Compact Storage Tables Where Users Have Defined Clustering and Value Columns

    [ https://issues.apache.org/jira/browse/CASSANDRA-16048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215155#comment-17215155 ] 

Jordan West commented on CASSANDRA-16048:
-----------------------------------------

Updated the branch to address [~marcuse]'s comment re: updated the flags in {{system_schema.tables}}. Had to move things around to account for the changes in CASSANDRA-16063. Updated the test as well. 

I skipped adding a flag since we can't detect and "undo" updating the tables that were updated. If folks feel strongly about the flag I can add it. 

Branch: https://github.com/apache/cassandra/compare/trunk...jrwest:jwest/16048

Tests: https://app.circleci.com/pipelines/github/jrwest/cassandra?branch=jwest%2F16048

> Safely Ignore Compact Storage Tables Where Users Have Defined Clustering and Value Columns
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16048
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16048
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/CQL
>            Reporter: Jordan West
>            Assignee: Jordan West
>            Priority: Normal
>             Fix For: 4.0-beta
>
>
> Some compact storage tables, specifically those where the user has defined both at least one clustering and the value column, can be safely handled in 4.0 because besides the DENSE flag they are not materially different post 3.0 and there is no visible change to the user facing schema after dropping compact storage. We can detect this case and allow these tables to silently drop the DENSE flag while still throwing a start-up error for COMPACT STORAGE tables that don’t meet the criteria. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org