You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/12/01 01:18:22 UTC

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 12:18 a.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
-------

Rebase


Repository: mesos


Description
-------

When --egress_unique_flow_per_container is enabled, we need to install a flow classifier (fq_codel) qdisc on egress side. This flag specifies where to install it in the hierarchy. By default, we install it at root. But, for example, if you have already installed HTB qdisc at root, you may want this to be installed in other place than root, specify an HTB class ID as its parent here.


Diffs (updated)
-----

  docs/configuration.md addcc7262584c19f9e5afe4b796c5fc4ecdb53b7 
  src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 
  src/linux/routing/handle.hpp 6deff85b52daa6b8771f127fea0d661cb5cd5e6a 
  src/linux/routing/handle.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 0865a71b1d79adcf62ca0f12d7ea0a23ebd0e786 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 09f819685a96cb4785423a5b2303d147719e273e 
  src/slave/flags.hpp 0858bdfa93f0c82c9654f9a11d1a251df2d41c36 
  src/slave/flags.cpp 31700b4f80cf346ab68f9e35d33d7cbb5ddc04cc 

Diff: https://reviews.apache.org/r/39417/diff/


Testing
-------

Manual tests, with and without a pre-installed HTB qdisc and classes.


Thanks,

Cong Wang

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/#review108455
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40497, 40506, 39415, 39416, 39417]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 1, 2015, 12:18 a.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39417/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 12:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When --egress_unique_flow_per_container is enabled, we need to install a flow classifier (fq_codel) qdisc on egress side. This flag specifies where to install it in the hierarchy. By default, we install it at root. But, for example, if you have already installed HTB qdisc at root, you may want this to be installed in other place than root, specify an HTB class ID as its parent here.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md addcc7262584c19f9e5afe4b796c5fc4ecdb53b7 
>   src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 
>   src/linux/routing/handle.hpp 6deff85b52daa6b8771f127fea0d661cb5cd5e6a 
>   src/linux/routing/handle.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 0865a71b1d79adcf62ca0f12d7ea0a23ebd0e786 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 09f819685a96cb4785423a5b2303d147719e273e 
>   src/slave/flags.hpp 0858bdfa93f0c82c9654f9a11d1a251df2d41c36 
>   src/slave/flags.cpp 31700b4f80cf346ab68f9e35d33d7cbb5ddc04cc 
> 
> Diff: https://reviews.apache.org/r/39417/diff/
> 
> 
> Testing
> -------
> 
> Manual tests, with and without a pre-installed HTB qdisc and classes.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>