[GitHub] [pulsar] sijie commented on a change in pull request #6365: Add retry when using async method to perform request in AsyncHttpConnector

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #6365: Add retry when using async method to perform request in AsyncHttpConnector
URL: https://github.com/apache/pulsar/pull/6365#discussion_r383473145
 
 

 ##########
 File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java
 ##########
 @@ -176,39 +153,83 @@ private URI replaceWithNew(InetSocketAddress address, URI uri) {
         return URI.create(newUri);
     }
 
+    @Override
+    public Future<?> apply(ClientRequest jerseyRequest, AsyncConnectorCallback callback) {
+        final CompletableFuture<ClientResponse> resp = new CompletableFuture<>();
+
 
+        CompletableFuture.runAsync(() -> {
 
 Review comment:
   I think we should rewrite this logic in async way. It seems that we try to wrap a sync code in an async way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services