You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "William Ferguson (JIRA)" <ji...@codehaus.org> on 2007/05/24 04:09:58 UTC

[jira] Created: (MRELEASE-236) ArrayindexoutofBoundsException rewriting the Poms for release

ArrayindexoutofBoundsException rewriting the Poms for release
-------------------------------------------------------------

                 Key: MRELEASE-236
                 URL: http://jira.codehaus.org/browse/MRELEASE-236
             Project: Maven 2.x Release Plugin
          Issue Type: Bug
    Affects Versions: 2.0-beta-6
            Reporter: William Ferguson
            Priority: Blocker
         Attachments: Stacktrace.txt

Just testing out maven-release-plugin-2.0-beta-6 prior to release and noticed that it always fails on release:prepare when it is rewriting the Poms.

Looking at the source code, the while loop at lines 249:252 of RewritePomsForReleasePhase class will always iterate past the end of the char arrays.
I'm not sure, but I suspect the appropriate soltuion is to check to ensure that i < tagPathChars.length and i < trunkPathChars.length within the loop and if so to break.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRELEASE-236) ArrayindexoutofBoundsException rewriting the Poms for release

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated MRELEASE-236:
---------------------------------------

    Fix Version/s:     (was: 2.0)
                   2.0-beta-7

> ArrayindexoutofBoundsException rewriting the Poms for release
> -------------------------------------------------------------
>
>                 Key: MRELEASE-236
>                 URL: http://jira.codehaus.org/browse/MRELEASE-236
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: William Ferguson
>            Assignee: Carlos Sanchez
>            Priority: Blocker
>             Fix For: 2.0-beta-7
>
>         Attachments: MRELEASE-236-patch.txt, pom.xml, Stacktrace.txt
>
>
> Just testing out maven-release-plugin-2.0-beta-6 prior to release and noticed that it always fails on release:prepare when it is rewriting the Poms.
> Looking at the source code, the while loop at lines 249:252 of RewritePomsForReleasePhase class will always iterate past the end of the char arrays.
> I'm not sure, but I suspect the appropriate soltuion is to check to ensure that i < tagPathChars.length and i < trunkPathChars.length within the loop and if so to break.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRELEASE-236) ArrayindexoutofBoundsException rewriting the Poms for release

Posted by "William Ferguson (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William Ferguson updated MRELEASE-236:
--------------------------------------

    Attachment: pom.xml

I've attached the POM that was causing the problem.
Though I think its self evident from the code what the problem is.

> ArrayindexoutofBoundsException rewriting the Poms for release
> -------------------------------------------------------------
>
>                 Key: MRELEASE-236
>                 URL: http://jira.codehaus.org/browse/MRELEASE-236
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: William Ferguson
>            Priority: Blocker
>         Attachments: pom.xml, Stacktrace.txt
>
>
> Just testing out maven-release-plugin-2.0-beta-6 prior to release and noticed that it always fails on release:prepare when it is rewriting the Poms.
> Looking at the source code, the while loop at lines 249:252 of RewritePomsForReleasePhase class will always iterate past the end of the char arrays.
> I'm not sure, but I suspect the appropriate soltuion is to check to ensure that i < tagPathChars.length and i < trunkPathChars.length within the loop and if so to break.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRELEASE-236) ArrayindexoutofBoundsException rewriting the Poms for release

Posted by "William Ferguson (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William Ferguson updated MRELEASE-236:
--------------------------------------

    Attachment: MRELEASE-236-patch.txt

I believe this patch fixes the issue.

> ArrayindexoutofBoundsException rewriting the Poms for release
> -------------------------------------------------------------
>
>                 Key: MRELEASE-236
>                 URL: http://jira.codehaus.org/browse/MRELEASE-236
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: William Ferguson
>            Priority: Blocker
>         Attachments: MRELEASE-236-patch.txt, pom.xml, Stacktrace.txt
>
>
> Just testing out maven-release-plugin-2.0-beta-6 prior to release and noticed that it always fails on release:prepare when it is rewriting the Poms.
> Looking at the source code, the while loop at lines 249:252 of RewritePomsForReleasePhase class will always iterate past the end of the char arrays.
> I'm not sure, but I suspect the appropriate soltuion is to check to ensure that i < tagPathChars.length and i < trunkPathChars.length within the loop and if so to break.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRELEASE-236) ArrayindexoutofBoundsException rewriting the Poms for release

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Sanchez closed MRELEASE-236.
-----------------------------------

         Assignee: Carlos Sanchez
       Resolution: Fixed
    Fix Version/s: 2.0

Fixed in release manager 1.0-alpha-4-SNAPSHOT

> ArrayindexoutofBoundsException rewriting the Poms for release
> -------------------------------------------------------------
>
>                 Key: MRELEASE-236
>                 URL: http://jira.codehaus.org/browse/MRELEASE-236
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: William Ferguson
>            Assignee: Carlos Sanchez
>            Priority: Blocker
>             Fix For: 2.0
>
>         Attachments: MRELEASE-236-patch.txt, pom.xml, Stacktrace.txt
>
>
> Just testing out maven-release-plugin-2.0-beta-6 prior to release and noticed that it always fails on release:prepare when it is rewriting the Poms.
> Looking at the source code, the while loop at lines 249:252 of RewritePomsForReleasePhase class will always iterate past the end of the char arrays.
> I'm not sure, but I suspect the appropriate soltuion is to check to ensure that i < tagPathChars.length and i < trunkPathChars.length within the loop and if so to break.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRELEASE-236) ArrayindexoutofBoundsException rewriting the Poms for release

Posted by "William Ferguson (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_97112 ] 

William Ferguson commented on MRELEASE-236:
-------------------------------------------

>From recollection it was originally 
scm:svn:http://iago.oz.hubbub.com.au/svn/test-project/trunk
but the release-plugin rewrote it during a prior release (which I have always found very confusing and frustrating).

I'll change all the Pom Urls so they point back to the trunk.
Are they no longer being rewritten?


> ArrayindexoutofBoundsException rewriting the Poms for release
> -------------------------------------------------------------
>
>                 Key: MRELEASE-236
>                 URL: http://jira.codehaus.org/browse/MRELEASE-236
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: William Ferguson
>            Priority: Blocker
>         Attachments: MRELEASE-236-patch.txt, pom.xml, Stacktrace.txt
>
>
> Just testing out maven-release-plugin-2.0-beta-6 prior to release and noticed that it always fails on release:prepare when it is rewriting the Poms.
> Looking at the source code, the while loop at lines 249:252 of RewritePomsForReleasePhase class will always iterate past the end of the char arrays.
> I'm not sure, but I suspect the appropriate soltuion is to check to ensure that i < tagPathChars.length and i < trunkPathChars.length within the loop and if so to break.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRELEASE-236) ArrayindexoutofBoundsException rewriting the Poms for release

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_97066 ] 

Emmanuel Venisse commented on MRELEASE-236:
-------------------------------------------

Why do you have a scm url like scm:svn:http://iago.oz.hubbub.com.au/svn/test-project/tags/test-project-1.1 and not a trunk or branch directory?
The exception appear when the tagPath string is part of the trunkPath or vice versa and that shouldn't be the case, but I'll fix it later.

> ArrayindexoutofBoundsException rewriting the Poms for release
> -------------------------------------------------------------
>
>                 Key: MRELEASE-236
>                 URL: http://jira.codehaus.org/browse/MRELEASE-236
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: William Ferguson
>            Priority: Blocker
>         Attachments: MRELEASE-236-patch.txt, pom.xml, Stacktrace.txt
>
>
> Just testing out maven-release-plugin-2.0-beta-6 prior to release and noticed that it always fails on release:prepare when it is rewriting the Poms.
> Looking at the source code, the while loop at lines 249:252 of RewritePomsForReleasePhase class will always iterate past the end of the char arrays.
> I'm not sure, but I suspect the appropriate soltuion is to check to ensure that i < tagPathChars.length and i < trunkPathChars.length within the loop and if so to break.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira