You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksandr Sorokoumov (Jira)" <ji...@apache.org> on 2021/09/19 12:29:00 UTC
[jira] [Commented] (CASSANDRA-16975) CompactionTask#runMayThrow
should not release new SSTables for offline transactions
[ https://issues.apache.org/jira/browse/CASSANDRA-16975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417326#comment-17417326 ]
Aleksandr Sorokoumov commented on CASSANDRA-16975:
--------------------------------------------------
||Branch||CI||
|[4.0|https://github.com/apache/cassandra/compare/trunk...Gerrrr:CASSANDRA-16975?expand=1] |[j8|https://app.circleci.com/pipelines/github/Gerrrr/cassandra/200/workflows/9f0978f7-b363-440d-aa88-1a8a2b4b6316] [j11|https://app.circleci.com/pipelines/github/Gerrrr/cassandra/200/workflows/6fbd5910-0e98-457f-8d1a-0b1f2048052c]|
> CompactionTask#runMayThrow should not release new SSTables for offline transactions
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-16975
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16975
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Aleksandr Sorokoumov
> Assignee: Aleksandr Sorokoumov
> Priority: Normal
> Fix For: 4.0.x
>
>
> Right now, {{CompactionTask#runMayThrow}} releases new SSTables for offline transactions ([code|https://github.com/apache/cassandra/blob/f7c71f65c000c2c3ef7df1b034b8fdd822a396d8/src/java/org/apache/cassandra/db/compaction/CompactionTask.java#L227-L230]). This change was added in CASSANDRA-8962, prior to the introduction of lifecycle transactions in CASSANDRA-8568. I suspect that this behavior might be undesired and could have just fallen through the cracks.
> To my knowledge, this code does not cause any known bugs solely because in-tree tools do not access the SSTables they produce before exiting. However, if someone is to write, say, offline compaction daemon, it might break on subsequent compactions because newly created SSTables will be released.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org