[GitHub] [beam] mxm commented on a change in pull request #12952: [BEAM-11022] Support bundle finalization for portable Flink in streaming.

[GitBox <gi...@apache.org>]

mxm commented on a change in pull request #12952:
URL: https://github.com/apache/beam/pull/12952#discussion_r500295025



##########
File path: sdks/python/apache_beam/runners/portability/flink_runner_test.py
##########
@@ -427,11 +427,29 @@ def test_sql(self):
 
 
 class FlinkRunnerTestStreaming(FlinkRunnerTest):
+  def __init__(self, *args, **kwargs):
+    super(FlinkRunnerTestStreaming, self).__init__(*args, **kwargs)
+    self.enable_commit = False
+
+  def setUp(self):
+    self.enable_commit = False
+
   def create_options(self):
     options = super(FlinkRunnerTestStreaming, self).create_options()
     options.view_as(StandardOptions).streaming = True
+    if self.enable_commit:
+      options._all_options['checkpointing_interval'] = 3000
+      options._all_options['shutdown_sources_after_idle_ms'] = 60000
     return options
 
+  def test_callbacks_with_exception(self):
+    self.enable_commit = True
+    super(FlinkRunnerTest, self).test_callbacks_with_exception()
+
+  def test_register_finalizations(self):
+    self.enable_commit = True
+    super(FlinkRunnerTest, self).test_register_finalizations()

Review comment:
       I've been thinking that we should support bundle finalization also with checkpointing disabled in an eager fashion. Does not have to be tackled here but would be nice to fix eventually because checkpointing is disabled by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org