You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/11/08 01:35:57 UTC

[GitHub] adriancole opened a new pull request #1891: Copies Base64 from Zipkin

adriancole opened a new pull request #1891: Copies Base64 from Zipkin
URL: https://github.com/apache/incubator-skywalking/pull/1891
 
 
   This copies the last copy of Base64 from Zipkin which can avoid a
   dependency on specific JRE. Notes in javadoc show its heritage. We
   didn't have unit tests: they can be backported from the source:
   
   https://github.com/square/okio/blob/cc1f5612506f86726c996be6b837b616892e12de/okio/src/test/kotlin/okio/ByteStringTest.kt#L230
   
   Thanks to @swankjesse who created the eldest github ancestor :P
   
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services