You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2014/02/10 03:58:47 UTC
svn commit: r1566495 -
/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java
Author: ggregory
Date: Mon Feb 10 02:58:46 2014
New Revision: 1566495
URL: http://svn.apache.org/r1566495
Log:
Do not use magic numbers.
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java
Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java?rev=1566495&r1=1566494&r2=1566495&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.java Mon Feb 10 02:58:46 2014
@@ -307,9 +307,9 @@ public class DefaultRolloverStrategy imp
String lowFilename = subst.replace(buf);
if (lowFilename.endsWith(EXT_GZIP)) {
- suffixLength = 3;
+ suffixLength = EXT_GZIP.length();
} else if (lowFilename.endsWith(EXT_ZIP)) {
- suffixLength = 4;
+ suffixLength = EXT_ZIP.length();
}
for (int i = lowIndex; i <= highIndex; i++) {