You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/09/21 19:43:14 UTC

[GitHub] [mynewt-core] andrzej-kaczmarek commented on pull request #2683: Memfault-SDK integration with MyNewt

andrzej-kaczmarek commented on pull request #2683:
URL: https://github.com/apache/mynewt-core/pull/2683#issuecomment-924327618


   I see few problems with this PR:
   - There are commits which introduce changes only to be removed in subsequent one, this should be cleaned up first
   - Do I understand correctly that change in `repository.yml` will make newt to download this 3rd party repo for each new project? If so, I do not really think this is a good idea.
   - syscfg name used in kernel/os that introduces dependency to MemFault package is defined in that package so it does not make any sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org