You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/08 04:03:18 UTC

[GitHub] [pulsar] AnonHxy opened a new pull request #14594: [Broker] tidy up code about dispatchRate

AnonHxy opened a new pull request #14594:
URL: https://github.com/apache/pulsar/pull/14594


   ### Motivation
   
   * Tidy up code about dispatchRate.
   *  No need `getTopicPolicyDispatchRate` or `getPoliciesDispatchRateAsync` when update broker type  dispatch rate
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
     
   - [x] `no-need-doc` 
     
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #14594: [Broker] tidy up code about dispatchRate

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14594:
URL: https://github.com/apache/pulsar/pull/14594#issuecomment-1061449445


   Add the UT `org.apache.pulsar.broker.service.BrokerDispatchRateLimiterTest` to test `BROKER` type `DispatchRateLimiter`   @gaoran10 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaoran10 commented on pull request #14594: [Broker] tidy up code about dispatchRate

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #14594:
URL: https://github.com/apache/pulsar/pull/14594#issuecomment-1061395385


   LGTM, could you check if there is any exsiting test to cover this logic?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14594: [Broker] tidy up code about dispatchRate

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14594:
URL: https://github.com/apache/pulsar/pull/14594


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org