[GitHub] [helix] dasahcc commented on a change in pull request #876: Helix domain

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #876: Helix domain
URL: https://github.com/apache/helix/pull/876#discussion_r389168774
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
 ##########
 @@ -200,6 +201,22 @@ private void joinCluster() {
     }
   }
 
+  private String ConstructDomainField(String faultDomain) {
+    Boolean topologyEnabled = _configAccessor.getClusterConfig(_clusterName).isTopologyAwareEnabled();
 
 Review comment:
   Do we need this? If we know the environment is Azure, then we can directly get the topology from AzureConstants instead of reading from ClusterConfig.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org