You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2020/03/27 21:04:07 UTC

[impala] branch master updated: IMPALA-9513: Fix TestKuduOperations.test_column_storage_attributes

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new c9da86d  IMPALA-9513: Fix TestKuduOperations.test_column_storage_attributes
c9da86d is described below

commit c9da86d00d5aba0aa91bfa59e47f2e28889b2a87
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Thu Mar 26 18:29:56 2020 -0700

    IMPALA-9513: Fix TestKuduOperations.test_column_storage_attributes
    
    When introducing Kudu date support, test_column_storage_attributes
    was modified to add the date datatype. The test expects the date
    to be represented in python as datetime.date. Instead, the date
    is a string in python, so the test consistently fails.
    
    This changes the test so that it expects a python string, and the
    test now passes.
    
    Change-Id: Ic198b72041fbe8fe7376c45356e484b304c6f16c
    Reviewed-on: http://gerrit.cloudera.org:8080/15567
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_kudu.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/query_test/test_kudu.py b/tests/query_test/test_kudu.py
index d31859a..7d9ab0b 100644
--- a/tests/query_test/test_kudu.py
+++ b/tests/query_test/test_kudu.py
@@ -34,7 +34,7 @@ import random
 import textwrap
 import threading
 import time
-from datetime import datetime, date
+from datetime import datetime
 from pytz import utc
 
 from tests.common.environ import ImpalaTestClusterProperties, HIVE_MAJOR_VERSION
@@ -435,7 +435,7 @@ class TestKuduOperations(KuduTestSuite):
         cursor.execute("select * from %s where id = %s" % (table_name, i))
         assert cursor.fetchall() == \
             [(i, True, 0, 0, 0, 0, 0.0, 0.0, '0', datetime(2009, 1, 1, 0, 0), 0,
-                 date(2010, 1, 1))]
+                '2010-01-01')]
         i += 1
     cursor.execute("select count(*) from %s" % table_name)
     print cursor.fetchall() == [(i, )]