[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6398: Reformat H3 index config spec

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6398:
URL: https://github.com/apache/incubator-pinot/pull/6398#discussion_r550675900



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/H3IndexColumn.java
##########
@@ -21,30 +21,48 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.google.common.base.Preconditions;
+import java.util.ArrayList;
 import java.util.List;
+import java.util.Map;
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.pinot.spi.config.BaseJsonConfig;
 
 
-public class H3IndexConfig extends BaseJsonConfig {
+public class H3IndexColumn extends BaseJsonConfig {

Review comment:
       Do we still need this class as a config class (json serializable), or this is just a helper class now? If the latter, maybe move this class to core for clarity?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org