You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/07/20 19:28:19 UTC

[GitHub] [beam] Abacn opened a new issue, #27584: [Bug]: Netty dependency version diverged

Abacn opened a new issue, #27584:
URL: https://github.com/apache/beam/issues/27584

   ### What happened?
   
   In the latest Beam SDK release (2.49.0), Netty dependency version has diverged:
   
   ```
   [INFO] |  +- org.apache.beam:beam-sdks-java-io-google-cloud-platform:jar:2.49.0:compile
   [INFO] |  |  +- io.netty:netty-handler:jar:4.1.77.Final:compile
   [INFO] |  |  |  +- io.netty:netty-common:jar:4.1.77.Final:compile
   [INFO] |  |  |  +- io.netty:netty-resolver:jar:4.1.77.Final:compile
   [INFO] |  |  |  +- io.netty:netty-buffer:jar:4.1.77.Final:compile
   [INFO] |  |  |  +- io.netty:netty-transport:jar:4.1.77.Final:compile
   [INFO] |  |  |  \- io.netty:netty-codec:jar:4.1.77.Final:compile
   [INFO] |  |  +- io.grpc:grpc-netty:jar:1.55.1:compile
   [INFO] |  |  |  +- io.netty:netty-codec-http2:jar:4.1.87.Final:compile
   [INFO] |  |  |  |  \- io.netty:netty-codec-http:jar:4.1.87.Final:compile
   [INFO] |  |  |  +- io.netty:netty-handler-proxy:jar:4.1.87.Final:runtime
   [INFO] |  |  |  |  \- io.netty:netty-codec-socks:jar:4.1.87.Final:runtime
   ```
   
   This is due to we pinned netty_version for direct dependencies of Beam here:
   
   https://github.com/apache/beam/blob/2c59a748b91a0988e0b8e332f18bd9db072c3e95/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L551
   
   while google_cloud_platform_libraries_bom sets netty version
   
   https://github.com/apache/beam/blob/2c59a748b91a0988e0b8e332f18bd9db072c3e95/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L705
   
   Routine bump of google_cloud_platform_libraries_bom should also update netty_version
   
   Manual update of google_cloud_platform_libraries_bom is error prone. In the long turn, we might consider use some tool to update (like dependabot)
   
   ### Issue Priority
   
   Priority: 2 (default / most bugs should be filed as P2)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [X] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn closed issue #27584: [Bug]: Netty dependency version diverged

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn closed issue #27584: [Bug]: Netty dependency version diverged
URL: https://github.com/apache/beam/issues/27584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on issue #27584: [Bug]: Netty dependency version diverged

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on issue #27584:
URL: https://github.com/apache/beam/issues/27584#issuecomment-1644481614

   Reported by @mutianf Thanks!
   
   We should also add a comment on this line: https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L551 to make it consistent with grpc netty version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org