You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2024/03/19 01:37:34 UTC
(dubbo) branch 3.2 updated: Fix NPE in NettyConnectionClient.toString (#13934)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch 3.2
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/3.2 by this push:
new 392260a30e Fix NPE in NettyConnectionClient.toString (#13934)
392260a30e is described below
commit 392260a30e3ead460469c6d7943ece598bb49809
Author: Albumen Kevin <jh...@gmail.com>
AuthorDate: Tue Mar 19 09:37:28 2024 +0800
Fix NPE in NettyConnectionClient.toString (#13934)
---
.../dubbo/remoting/transport/netty4/NettyConnectionClient.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionClient.java b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionClient.java
index 6f3171363c..ab8f39bcf7 100644
--- a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionClient.java
+++ b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionClient.java
@@ -31,6 +31,7 @@ import org.apache.dubbo.remoting.transport.netty4.ssl.SslClientTlsHandler;
import org.apache.dubbo.remoting.transport.netty4.ssl.SslContexts;
import org.apache.dubbo.remoting.utils.UrlUtils;
+import java.util.Optional;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
@@ -337,7 +338,9 @@ public class NettyConnectionClient extends AbstractConnectionClient {
@Override
public String toString() {
return super.toString() + " (Ref=" + this.getCounter() + ",local="
- + (getChannel() == null ? null : getChannel().getLocalAddress()) + ",remote=" + getRemoteAddress();
+ + Optional.ofNullable(getChannel())
+ .map(Channel::getLocalAddress)
+ .orElse(null) + ",remote=" + getRemoteAddress();
}
class ConnectionListener implements ChannelFutureListener {