You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "icexelloss (via GitHub)" <gi...@apache.org> on 2023/04/20 21:55:21 UTC

[GitHub] [arrow] icexelloss commented on pull request #34912: GH-34911: [C++] Add first and last aggregator

icexelloss commented on PR #34912:
URL: https://github.com/apache/arrow/pull/34912#issuecomment-1516990642

   @westonpace I am reasonably happy about the current code and would like to request a review from you.
   
   This PR is a little overwhelming because lots of test, boiler plate code and templates. But I will mark the actual important piece (I think) for you. Hopefully makes it a little easier. I also included some check marks in the overview to summarize that I did.  The main points that we discussed last time should be addressed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org