[GitHub] [maven-jarsigner] elharo commented on a diff in pull request #3: [MNG-6829] Replace StringUtils#isEmpty(String) & #isNotEmpty(String)

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on code in PR #3:
URL: https://github.com/apache/maven-jarsigner/pull/3#discussion_r1202282976


##########
src/main/java/org/apache/maven/shared/jarsigner/JarSignerCommandLineBuilder.java:
##########
@@ -82,28 +82,28 @@ public Commandline build( JarSignerRequest request )
         }
 
         String storetype = request.getStoretype();
-        if ( !StringUtils.isEmpty( storetype ) )
+        if ( !(storetype == null || storetype.isEmpty()) )
         {
             cli.createArg().setValue( "-storetype" );
             cli.createArg().setValue( storetype );
         }
 
         String providerName = request.getProviderName();
-        if ( !StringUtils.isEmpty( providerName ) )
+        if ( !(providerName == null || providerName.isEmpty()) )
         {
             cli.createArg().setValue( "-providerName" );
             cli.createArg().setValue( providerName );
         }
 
         String providerClass = request.getProviderClass();
-        if ( !StringUtils.isEmpty( providerClass ) )
+        if ( !(providerClass == null || providerClass.isEmpty()) )

Review Comment:
   I guess the recipe doesn't pick up the ! in StringUtils.isEmpty( providerClass )? This isn't the same replacement as StringUtils.isNotEmpty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org