[GitHub] [unomi] pmi commented on a change in pull request #175: UNOMI-354 Add CDP_LongProperty input and output types

[GitBox <gi...@apache.org>]

pmi commented on a change in pull request #175:
URL: https://github.com/apache/unomi/pull/175#discussion_r454885383



##########
File path: graphql/cxs-impl/src/main/java/org/apache/unomi/graphql/types/input/property/CDPLongPropertyInput.java
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.unomi.graphql.types.input.property;
+
+import graphql.annotations.annotationTypes.GraphQLField;
+import graphql.annotations.annotationTypes.GraphQLName;
+import graphql.annotations.annotationTypes.GraphQLPrettify;
+import org.apache.unomi.api.PropertyType;
+
+import java.util.List;
+
+@GraphQLName("CDP_LongPropertyInput")
+public class CDPLongPropertyInput extends BaseCDPPropertyInput {
+
+    private Long minValue;
+    private Long maxValue;
+    private Long defaultValue;
+
+    public CDPLongPropertyInput(@GraphQLName("name") String name,
+                                @GraphQLName("minOccurrences") Integer minOccurrences,
+                                @GraphQLName("maxOccurrences") Integer maxOccurrences,
+                                @GraphQLName("tags") List<String> tags,
+                                @GraphQLName("minValue") Long minValue,
+                                @GraphQLName("maxValue") Long maxValue,
+                                @GraphQLName("defaultValue") Long defaultValue) {
+        super(name, minOccurrences, maxOccurrences, tags);
+        this.minValue = minValue;
+        this.maxValue = maxValue;
+        this.defaultValue = defaultValue;
+    }
+
+    @GraphQLField
+    @GraphQLPrettify
+    public Long getMinValue() {
+        return minValue;
+    }
+
+    @GraphQLField
+    @GraphQLPrettify
+    public Long getMaxValue() {
+        return maxValue;
+    }
+
+    @GraphQLField
+    @GraphQLPrettify
+    public Long getDefaultValue() {
+        return defaultValue;
+    }
+
+    @Override
+    public String getCDPPropertyType() {
+        return "long";
+    }
+
+    @Override
+    public void updateType(final PropertyType type) {
+        if (type == null) {
+            return;
+        }
+        super.updateType(type);
+        type.setDefaultValue(defaultValue != null ? defaultValue.toString() : null);
+        if (minValue != null || maxValue != null) {
+            final Double from = minValue != null ? minValue.doubleValue() : null;
+            final Double to = maxValue != null && (minValue == null || maxValue >= minValue) ? maxValue.doubleValue() : null;
+            updateDefaultNumericRange(type, from, to);

Review comment:
       This is declared in BaseCDPPropertyInput, which is the parent class for all property inputs.
   
   It's a custom method to save min/max property values as unomi numeric range with pre-defined name *defaultRange* because unomi doesn't have dedicated fields for saving min/max values as of now.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org