You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/09 12:02:14 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #155: diffs when running scalafmtAll
pjfanning opened a new pull request, #155:
URL: https://github.com/apache/incubator-pekko/pull/155
I ran `sbt scalafmtAll javafmtAll scalafmtSbt` and got these diffs
Just thought it best to do a dedicated PR instead of having these appear in PR dedicated to fixing a particular issue (but that also needs scalafmt to be run - thus accidentally adding these unrelated diffs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #155: diffs when running scalafmtAll
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #155:
URL: https://github.com/apache/incubator-pekko/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] spangaer commented on pull request #155: diffs when running scalafmtAll
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #155:
URL: https://github.com/apache/incubator-pekko/pull/155#issuecomment-1425505784
- Scalafmt version was updated too (which wouldn't be caught by GA as mentioned by @jrudolph )
- Sometimes a formatter needs a couple of iterations to converge
- ...
🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #155: diffs when running scalafmtAll
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #155:
URL: https://github.com/apache/incubator-pekko/pull/155#issuecomment-1424205458
@jrudolph I don't really know why these diffs were not failing the build - I'm pretty sure the CI action is running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #155: diffs when running scalafmtAll
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #155:
URL: https://github.com/apache/incubator-pekko/pull/155#issuecomment-1424213212
> @jrudolph I don't really know why these diffs were not failing the build - I'm pretty sure the CI action is running
The GHA is only checking changed files, so maybe they were last checked before the check was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org