You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/09/07 09:48:33 UTC
Review Request 38151: FALCON-1250: Throw error when keys in
startup.properties do not start with "*." or domain+"."
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38151/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties only loads the keys that start with domain + "." or "*.". All other keys are ignored.
If the keys do not start with domain + "." or "*.", it is probably because the user made a typo or mistake in the startup.properties. Instead of ignoring these keys, I propose that an error should be thrown.
Diffs
-----
common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 1d8cf49
common/src/main/resources/startup.properties c48188c
Diff: https://reviews.apache.org/r/38151/diff/
Testing
-------
Done.
Thanks,
Narayan Periwal
Re: Review Request 38151: FALCON-1250: Throw error when keys in
startup.properties do not start with "*." or domain+"."
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38151/#review97999
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Sept. 7, 2015, 7:48 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38151/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 7:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties only loads the keys that start with domain + "." or "*.". All other keys are ignored.
>
> If the keys do not start with domain + "." or "*.", it is probably because the user made a typo or mistake in the startup.properties. Instead of ignoring these keys, I propose that an error should be thrown.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 1d8cf49
> common/src/main/resources/startup.properties c48188c
>
> Diff: https://reviews.apache.org/r/38151/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38151: FALCON-1250: Throw error when keys in
startup.properties do not start with "*." or domain+"."
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38151/#review97992
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Sept. 7, 2015, 7:48 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38151/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 7:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties only loads the keys that start with domain + "." or "*.". All other keys are ignored.
>
> If the keys do not start with domain + "." or "*.", it is probably because the user made a typo or mistake in the startup.properties. Instead of ignoring these keys, I propose that an error should be thrown.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 1d8cf49
> common/src/main/resources/startup.properties c48188c
>
> Diff: https://reviews.apache.org/r/38151/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 38151: FALCON-1250: Throw error when keys in
startup.properties do not start with "*." or domain+"."
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38151/#review97912
-----------------------------------------------------------
Ship it!
Ship It!
- pavan kumar kolamuri
On Sept. 7, 2015, 7:48 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38151/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 7:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> In org.apache.falcon.util.ApplicationProperties.java, method doLoadProperties only loads the keys that start with domain + "." or "*.". All other keys are ignored.
>
> If the keys do not start with domain + "." or "*.", it is probably because the user made a typo or mistake in the startup.properties. Instead of ignoring these keys, I propose that an error should be thrown.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 1d8cf49
> common/src/main/resources/startup.properties c48188c
>
> Diff: https://reviews.apache.org/r/38151/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Narayan Periwal
>
>