You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/11/11 23:20:17 UTC

[jira] [Commented] (HDFS-5312) Refactor DFSUtil#getInfoServer to return an URI

    [ https://issues.apache.org/jira/browse/HDFS-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819498#comment-13819498 ] 

Hadoop QA commented on HDFS-5312:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12613209/HDFS-5312.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5387//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5387//console

This message is automatically generated.

> Refactor DFSUtil#getInfoServer to return an URI
> -----------------------------------------------
>
>                 Key: HDFS-5312
>                 URL: https://issues.apache.org/jira/browse/HDFS-5312
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-5312.000.patch, HDFS-5312.001.patch, HDFS-5312.002.patch
>
>
> DFSUtil#getInfoServer() returns only the authority (i.e., host+port) when searching for the http / https server. The task of figuring out which scheme that the authority supposes to use. Unsurprisingly, the task is cumbersome, and the code performs the task in an inconsistent way.
> This JIRA proposes to return an URI object instead of a string, so that the scheme is an inherent parts of the return value, which eliminates the task of figuring out the scheme by design. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)