You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/08 10:06:09 UTC
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2822: arch/riscv: Unify 32/64 implementations and remove dead ports
btashton commented on a change in pull request #2822:
URL: https://github.com/apache/incubator-nuttx/pull/2822#discussion_r571919479
##########
File path: arch/risc-v/include/arch.h
##########
@@ -42,70 +30,47 @@
****************************************************************************/
#include <nuttx/config.h>
-
-#ifndef __ASSEMBLY__
-# include <stdint.h>
-#endif
-
#include <arch/csr.h>
-#ifdef CONFIG_ARCH_RV32IM
-# include <arch/rv32im/arch.h>
-#endif
-
-#ifdef CONFIG_ARCH_RV64GC
-# include <arch/rv64gc/arch.h>
-#endif
-
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
-/* Macros to get the core and vendor ID, HART, arch and ISA codes, etc.
- */
-
-#ifdef CONFIG_RV32IM_SYSTEM_CSRRS_SUPPORT
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
-uint32_t up_getmisa(void);
-uint32_t up_getarchid(void);
-uint32_t up_getimpid(void);
-uint32_t up_getvendorid(void);
-uint32_t up_gethartid(void);
+#ifndef __ASSEMBLY__
+#ifdef __LP64__
+typedef uint64_t reg_t;
Review comment:
@xiaoxiang781216 How do you think we should approach this? I would prefer to use something like uintptr_t, but that does not feel quite right either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org