Re: [PR] feat(local-dev): reuse the stored storage profile when refreshing the Lakekeeper warehouse [texera]

["kz930 (via GitHub)" <gi...@apache.org>]

kz930 commented on code in PR #7935:
URL: https://github.com/apache/texera/pull/7935#discussion_r3848536599


##########
bin/single-node/docker-compose.yml:
##########
@@ -228,12 +228,19 @@ services:
           # RESTException. Refresh the stored endpoint on every run (#6195).
           echo "Lakekeeper Warehouse '$$STORAGE_ICEBERG_CATALOG_REST_WAREHOUSE_NAME' already exists. Refreshing its storage endpoint to '$$STORAGE_S3_ENDPOINT'..."
           WAREHOUSE_ID=$$(jq -r --arg name "$$STORAGE_ICEBERG_CATALOG_REST_WAREHOUSE_NAME" '.warehouses[]? | select(.name == $$name) | .id' /tmp/warehouses.txt)
+
+          # Lakekeeper treats the key prefix as immutable and rejects a payload
+          # that would change it, taking the endpoint down with it. A warehouse
+          # created before the prefix was configured has none, so send back what
+          # is stored. jq emits it as JSON, so it needs no quotes below.
+          STORED_KEY_PREFIX=$$(jq -c --arg name "$$STORAGE_ICEBERG_CATALOG_REST_WAREHOUSE_NAME" '.warehouses[]? | select(.name == $$name) | ."storage-profile"."key-prefix"' /tmp/warehouses.txt)

Review Comment:
   Good call, done: the update now takes the stored profile from the listing and overrides only the endpoint, so region is covered too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org