You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/06/10 01:04:13 UTC

Removing conversion of & to & and vice versa when generating url (issue1632042)

Good catch in the MutableContent!


http://codereview.appspot.com/1632042/diff/2001/3003
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java
(left):

http://codereview.appspot.com/1632042/diff/2001/3003#oldcode169
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java:169:
elem.getNamespaceURI() == null &&
Can you create a test case that show it is not needed? (or maybe I
didn't see it)

http://codereview.appspot.com/1632042/diff/2001/3005
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java
(right):

http://codereview.appspot.com/1632042/diff/2001/3005#newcode135
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ConcatVisitor.java:135:
concatUri.getUri().toString());
I guess there is a reason why it was added, maybe the right solution is
to fix the parser?

http://codereview.appspot.com/1632042/show