You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2024/05/09 17:00:23 UTC
[PR] Updated spotbugs and fixed all the warnings. [datasketches-memory]
leerho opened a new pull request, #182:
URL: https://github.com/apache/datasketches-memory/pull/182
This is for a bug fix release 2.2.1. However, because the new version of SpotBugs found new warnings, I wanted to fix those issues as well. I also upgraded Maven plugins in POM to their more recent versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Updated spotbugs and fixed all the warnings. [datasketches-memory]
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on code in PR #182:
URL: https://github.com/apache/datasketches-memory/pull/182#discussion_r1597543101
##########
.github/workflows/auto-jdk-matrix.yml:
##########
@@ -0,0 +1,67 @@
+name: DataSketches-Memory Auto JDK Matrix Test & Install
+
+on:
+ pull_request:
+ push:
+ # branches: [ master ]
+ workflow_dispatch:
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g
Review Comment:
Do we actually need 4g??
##########
.github/workflows/auto-jdk-matrix.yml:
##########
@@ -0,0 +1,67 @@
+name: DataSketches-Memory Auto JDK Matrix Test & Install
+
+on:
+ pull_request:
+ push:
+ # branches: [ master ]
Review Comment:
Dunno if you wanted this commented out? Certainly not a blocker to the PR either way, but ideally either uncomment or remove the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Updated spotbugs and fixed all the warnings. [datasketches-memory]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #182:
URL: https://github.com/apache/datasketches-memory/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Updated spotbugs and fixed all the warnings. [datasketches-memory]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on code in PR #182:
URL: https://github.com/apache/datasketches-memory/pull/182#discussion_r1597551389
##########
.github/workflows/auto-jdk-matrix.yml:
##########
@@ -0,0 +1,67 @@
+name: DataSketches-Memory Auto JDK Matrix Test & Install
+
+on:
+ pull_request:
+ push:
+ # branches: [ master ]
+ workflow_dispatch:
+
+env:
+ MAVEN_OPTS: -Xmx4g -Xms1g
Review Comment:
Oh jees, that has been there for a long time, I don't remember why I made it 4g at the time.
##########
.github/workflows/auto-jdk-matrix.yml:
##########
@@ -0,0 +1,67 @@
+name: DataSketches-Memory Auto JDK Matrix Test & Install
+
+on:
+ pull_request:
+ push:
+ # branches: [ master ]
Review Comment:
Yeah, it needs to be uncommented before it goes into release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org