Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367464423


##########
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala:
##########
@@ -166,117 +158,6 @@ private[spark] object CryptoStreamUtils extends Logging {
 
   }
 
-  /**
-   * SPARK-25535. The commons-crypto library will throw InternalError if something goes
-   * wrong, and leave bad state behind in the Java wrappers, so it's not safe to use them
-   * afterwards. This wrapper detects that situation and avoids further calls into the
-   * commons-crypto code, while still allowing the underlying streams to be closed.
-   *
-   * This should be removed once CRYPTO-141 is fixed (and Spark upgrades its commons-crypto

Review Comment:
   CRYPTO-141 is fixed in 1.1.0 (https://commons.apache.org/proper/commons-crypto/changes-report.html). Currently used commons-crypto library in Spark is 1.1.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org