[jira] [Comment Edited] (FLINK-32727) Adding capability of setting Attributes in Google Pub/Sub sink

["Vetle Leinonen-Roeim (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-32727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766261#comment-17766261 ] 

Vetle Leinonen-Roeim edited comment on FLINK-32727 at 9/18/23 8:20 AM:
-----------------------------------------------------------------------

[~yinghai] can you attach a patch against the current main branch?

I've attached mine, please check it out.


was (Author: vetle@roeim.net):
[~yinghai] can you attach a patch against the current main branch?

> Adding capability of setting Attributes in Google Pub/Sub sink
> --------------------------------------------------------------
>
>                 Key: FLINK-32727
>                 URL: https://issues.apache.org/jira/browse/FLINK-32727
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Google Cloud PubSub
>            Reporter: Yinghai Zhao
>            Priority: Major
>         Attachments: pubsub-attributes-0.patch
>
>
> Currently the Google PubSub Sink can only publish messages with data in body. To take full advantage of Google PubSub, having the ability to set attributes is important, so subscriptions can filter on attributes and consume part of the event stream.
> Google Doc on [message|https://cloud.google.com/pubsub/docs/reference/rest/v1/PubsubMessage] and [subscription.|https://cloud.google.com/pubsub/docs/subscription-message-filter]
>  
> I have a basic idea on this and had a patch working locally. Wondering how I can incorporate this back to the official connector.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)