You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/02 06:14:52 UTC

[GitHub] [spark] mridulm commented on pull request #38428: [SPARK-40912][CORE][WIP] Overhead of Exceptions in KryoDeserializationStream

mridulm commented on PR #38428:
URL: https://github.com/apache/spark/pull/38428#issuecomment-1299630091

   The PR as such looks reasonable to me - can we add a test to explicitly test for EOF behavior ?
   
   +CC @JoshRosen who had worked on this in the distant past :-)
   +CC @Ngone51 
   
   I want to make sure there are more eyes on this change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org