You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/08/13 01:46:00 UTC

[jira] [Comment Edited] (CASSANDRA-16725) Implement nodetool getauditlog command

    [ https://issues.apache.org/jira/browse/CASSANDRA-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398376#comment-17398376 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-16725 at 8/13/21, 1:45 AM:
---------------------------------------------------------------------------

Thanks for fruitful discussions and addressing review comments as per what we agreed together.
I just left a few super nits, mostly for typos, and we need to deprecate _enableAuditLog_ also in _StorageServiceMBean_.
Unfortunately, I noticed that _DatabaseDescriptorRefTest_ is failing. I suspect it will be a test issue only but it is 10pm already so I can take a look tomorrow morning with fresh eyes if needed. Not doing well enough now for debugging.
Further to that, I think we miss only final rebase and full CI run + the votes of the other two reviewers. We are getting there. Thank you for your hard work! :-) 


was (Author: e.dimitrova):
Thanks for fruitful discussions and addressing review comments as per what we agreed together.
I just left a few super nits mostly for typos and we need to deprecate _enableAuditLog_ also in _StorageServiceMBean_.
Unfortunately, I noticed that _DatabaseDescriptorRefTest_ is failing. I suspect it will be a test issue only but it is 10pm already so I can take a look tomorrow morning with fresh eyes if needed. 
Further to that, I think we miss only final rebase and full CI run + the votes of the other two reviews. We are getting there. Thank you for your hard work! :-) 

> Implement nodetool getauditlog command
> --------------------------------------
>
>                 Key: CASSANDRA-16725
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16725
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tool/auditlogging
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.1
>
>          Time Spent: 12h 50m
>  Remaining Estimate: 0h
>
> There is getfullquerylog already, there is not any reason why getauditlog should not be there too. A user can not retrieve runtime configuration of Audit log, it might be only enabled and disabled via jmx but its state can not be queried in runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org