You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "imzs (via GitHub)" <gi...@apache.org> on 2023/02/24 03:28:10 UTC
[GitHub] [rocketmq] imzs opened a new issue, #6169: NPE found when timerWheel disabled
imzs opened a new issue, #6169:
URL: https://github.com/apache/rocketmq/issues/6169
```
2023-02-24 11:12:10 INFO PopReviveService_0 - reviveQueueId=0, old offset is -1
2023-02-24 11:12:10 INFO PopReviveService_1 - reviveQueueId=1, old offset is -1
2023-02-24 11:12:10 ERROR PopReviveService_2 - reviveQueueId=2, revive error
java.lang.NullPointerException: null
at org.apache.rocketmq.broker.processor.PopReviveService.consumeReviveMessage(PopReviveService.java:327)
at org.apache.rocketmq.broker.processor.PopReviveService.run(PopReviveService.java:606)
at java.lang.Thread.run(Thread.java:766)
2023-02-24 11:12:10 ERROR PopReviveService_6 - reviveQueueId=6, revive error
java.lang.NullPointerException: null
at org.apache.rocketmq.broker.processor.PopReviveService.consumeReviveMessage(PopReviveService.java:327)
at org.apache.rocketmq.broker.processor.PopReviveService.run(PopReviveService.java:606)
at java.lang.Thread.run(Thread.java:766)
2023-02-24 11:12:10 ERROR PopReviveService_4 - reviveQueueId=4, revive error
```
TimerMessageStore could be null when timerWheelEnable setting false.
Since some processors are related with [timerWheelEnable], such as PopMessageProcessor, AckMessageProcessor, and only initialized once before startup, so can we check this switch and skip instantiation when disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma commented on issue #6169: NPE found when timerWheel disabled
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma commented on issue #6169:
URL: https://github.com/apache/rocketmq/issues/6169#issuecomment-1443579758
The timerWheel-based timer message serves as the foundation of PopMessage so that it is necessary to set timerWheelEnable to true to use PopMessage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #6169: NPE found when timerWheel disabled
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on issue #6169:
URL: https://github.com/apache/rocketmq/issues/6169#issuecomment-1445029224
Hi @imzs @fuyou001 @drpmma IMO, it is not elegant to keep reporting NPE in the log when the user neither uses pop consume nor timerWheel. Maybe we can optimize it, when users disable timerWheel, they will be forced to not use pop consume and invalid NPE logs will not print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] fuyou001 commented on issue #6169: NPE found when timerWheel disabled
Posted by "fuyou001 (via GitHub)" <gi...@apache.org>.
fuyou001 commented on issue #6169:
URL: https://github.com/apache/rocketmq/issues/6169#issuecomment-1443371007
set timerWheelEnable true, PoP feature dependency timerWheel feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma closed issue #6169: NPE found when timerWheel disabled
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma closed issue #6169: NPE found when timerWheel disabled
URL: https://github.com/apache/rocketmq/issues/6169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org