You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2011/07/12 02:40:11 UTC
Review Request: HIVE-1734. Implement map_keys() and map_values() UDFs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1082/
-----------------------------------------------------------
Review request for hive.
Summary
-------
This patch adds map_keys(map) and map_values(map) UDFs.
This addresses bug HIVE-1734.
https://issues.apache.org/jira/browse/HIVE-1734
Diffs
-----
ql/src/test/results/clientpositive/udf_map_values.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_map_keys.q.out PRE-CREATION
ql/src/test/queries/clientpositive/udf_map_values.q PRE-CREATION
ql/src/test/results/clientnegative/udf_map_keys_arg_num.q.out PRE-CREATION
ql/src/test/results/clientnegative/udf_map_keys_arg_type.q.out PRE-CREATION
ql/src/test/results/clientnegative/udf_map_values_arg_num.q.out PRE-CREATION
ql/src/test/results/clientnegative/udf_map_values_arg_type.q.out PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out d4f6c98
ql/src/test/queries/clientnegative/udf_map_values_arg_num.q PRE-CREATION
ql/src/test/queries/clientnegative/udf_map_values_arg_type.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_map_keys.q PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 16a207e
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java PRE-CREATION
ql/src/test/queries/clientnegative/udf_map_keys_arg_num.q PRE-CREATION
ql/src/test/queries/clientnegative/udf_map_keys_arg_type.q PRE-CREATION
Diff: https://reviews.apache.org/r/1082/diff
Testing
-------
Thanks,
Carl
Re: Review Request: HIVE-1734. Implement map_keys() and map_values() UDFs
Posted by Carl Steinbach <ca...@cloudera.com>.
> On 2011-08-01 10:03:11, Amareshwari Sriramadasu wrote:
> > ql/src/test/results/clientpositive/udf_map_keys.q.out, line 40
> > <https://reviews.apache.org/r/1082/diff/1/?file=22333#file22333line40>
> >
> > Shouldn't the output be ["a", "b", "c"] here?
The set of key/value pairs in a Map is unordered, and the same property also applies if you look only at the set of keys, or the set of values. Unfortunately, Hive's type system does not have a 'set' type, so we're forced to return the result of map_keys() and map_values() as an array, which implies that the set is ordered when it really isn't. If you want to apply a specific ordering property to the output of map_keys() or map_values(), then you would have to do this with a sort(array) UDF (which is not yet implemented).
> On 2011-08-01 10:03:11, Amareshwari Sriramadasu wrote:
> > ql/src/test/results/clientpositive/udf_map_values.q.out, line 40
> > <https://reviews.apache.org/r/1082/diff/1/?file=22334#file22334line40>
> >
> > Shouldn't the output be [1,2,3] instead of [2,1,3]?
No. See previous comment.
- Carl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1082/#review1247
-----------------------------------------------------------
On 2011-07-12 00:40:11, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1082/
> -----------------------------------------------------------
>
> (Updated 2011-07-12 00:40:11)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> This patch adds map_keys(map) and map_values(map) UDFs.
>
>
> This addresses bug HIVE-1734.
> https://issues.apache.org/jira/browse/HIVE-1734
>
>
> Diffs
> -----
>
> ql/src/test/results/clientpositive/udf_map_values.q.out PRE-CREATION
> ql/src/test/results/clientpositive/udf_map_keys.q.out PRE-CREATION
> ql/src/test/queries/clientpositive/udf_map_values.q PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_keys_arg_num.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_keys_arg_type.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_values_arg_num.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_values_arg_type.q.out PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out d4f6c98
> ql/src/test/queries/clientnegative/udf_map_values_arg_num.q PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_values_arg_type.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_map_keys.q PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 16a207e
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_keys_arg_num.q PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_keys_arg_type.q PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1082/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>
Re: Review Request: HIVE-1734. Implement map_keys() and map_values() UDFs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1082/#review1247
-----------------------------------------------------------
ql/src/test/results/clientpositive/udf_map_keys.q.out
<https://reviews.apache.org/r/1082/#comment2850>
Shouldn't the output be ["a", "b", "c"] here?
ql/src/test/results/clientpositive/udf_map_values.q.out
<https://reviews.apache.org/r/1082/#comment2851>
Shouldn't the output be [1,2,3] instead of [2,1,3]?
- Amareshwari
On 2011-07-12 00:40:11, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1082/
> -----------------------------------------------------------
>
> (Updated 2011-07-12 00:40:11)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> This patch adds map_keys(map) and map_values(map) UDFs.
>
>
> This addresses bug HIVE-1734.
> https://issues.apache.org/jira/browse/HIVE-1734
>
>
> Diffs
> -----
>
> ql/src/test/results/clientpositive/udf_map_values.q.out PRE-CREATION
> ql/src/test/results/clientpositive/udf_map_keys.q.out PRE-CREATION
> ql/src/test/queries/clientpositive/udf_map_values.q PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_keys_arg_num.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_keys_arg_type.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_values_arg_num.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_values_arg_type.q.out PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out d4f6c98
> ql/src/test/queries/clientnegative/udf_map_values_arg_num.q PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_values_arg_type.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_map_keys.q PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 16a207e
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_keys_arg_num.q PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_keys_arg_type.q PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1082/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>
Re: Review Request: HIVE-1734. Implement map_keys() and map_values() UDFs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1082/#review1316
-----------------------------------------------------------
Ship it!
Will commit once tests pass.
- Amareshwari
On 2011-08-05 18:44:36, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1082/
> -----------------------------------------------------------
>
> (Updated 2011-08-05 18:44:36)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> This patch adds map_keys(map) and map_values(map) UDFs.
>
>
> This addresses bug HIVE-1734.
> https://issues.apache.org/jira/browse/HIVE-1734
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 13584c1
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_keys_arg_num.q PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_keys_arg_type.q PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_values_arg_num.q PRE-CREATION
> ql/src/test/queries/clientnegative/udf_map_values_arg_type.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_map_keys.q PRE-CREATION
> ql/src/test/queries/clientpositive/udf_map_values.q PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_keys_arg_num.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_keys_arg_type.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_values_arg_num.q.out PRE-CREATION
> ql/src/test/results/clientnegative/udf_map_values_arg_type.q.out PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out d4f6c98
> ql/src/test/results/clientpositive/udf_map_keys.q.out PRE-CREATION
> ql/src/test/results/clientpositive/udf_map_values.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1082/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>
Re: Review Request: HIVE-1734. Implement map_keys() and map_values() UDFs
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1082/
-----------------------------------------------------------
(Updated 2011-08-05 18:44:36.743395)
Review request for hive.
Summary
-------
This patch adds map_keys(map) and map_values(map) UDFs.
This addresses bug HIVE-1734.
https://issues.apache.org/jira/browse/HIVE-1734
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 13584c1
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java PRE-CREATION
ql/src/test/queries/clientnegative/udf_map_keys_arg_num.q PRE-CREATION
ql/src/test/queries/clientnegative/udf_map_keys_arg_type.q PRE-CREATION
ql/src/test/queries/clientnegative/udf_map_values_arg_num.q PRE-CREATION
ql/src/test/queries/clientnegative/udf_map_values_arg_type.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_map_keys.q PRE-CREATION
ql/src/test/queries/clientpositive/udf_map_values.q PRE-CREATION
ql/src/test/results/clientnegative/udf_map_keys_arg_num.q.out PRE-CREATION
ql/src/test/results/clientnegative/udf_map_keys_arg_type.q.out PRE-CREATION
ql/src/test/results/clientnegative/udf_map_values_arg_num.q.out PRE-CREATION
ql/src/test/results/clientnegative/udf_map_values_arg_type.q.out PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out d4f6c98
ql/src/test/results/clientpositive/udf_map_keys.q.out PRE-CREATION
ql/src/test/results/clientpositive/udf_map_values.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1082/diff
Testing
-------
Thanks,
Carl