You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by incarosegit <gi...@git.apache.org> on 2016/04/29 17:48:22 UTC

[GitHub] activemq-artemis pull request: Change keep alive ratio to 1.5 from...

GitHub user incarosegit opened a pull request:

    https://github.com/apache/activemq-artemis/pull/497

    Change keep alive ratio to 1.5 from 0.75

    Fixes: ARTEMIS-397
    
    From mqtt specs:
    
    \u201cIf the Keep Alive value is non-zero and the Server does not receive a
    Control Packet from the Client within one and a half times the Keep
    Alive time period, it MUST disconnect the Network Connection to the
    Client as if the network had failed [MQTT-3.1.2-24]. \u201c

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/incarosegit/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #497
    
----
commit 6bdad3db2a8e19069f7d1d5b44c97ceb0fc05b92
Author: Diego Bes <db...@tangome-macbook-pro.local>
Date:   2016-04-29T15:43:25Z

    Change keep alive ratio to 1.5 from 0.75
    
    Fixes: ARTEMIS-397
    
    From mqtt specs:
    
    \u201cIf the Keep Alive value is non-zero and the Server does not receive a
    Control Packet from the Client within one and a half times the Keep
    Alive time period, it MUST disconnect the Network Connection to the
    Client as if the network had failed [MQTT-3.1.2-24]. \u201c

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: [ARTEMIS-397] Change mqtt connectio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/497


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: [ARTEMIS-397] Change mqtt connectio...

Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/497#issuecomment-216523280
  
    Merging thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---