You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/24 17:23:44 UTC

[GitHub] [bookkeeper] lordcheng10 opened a new pull request, #3357: fix journalCbQueueSize compute

lordcheng10 opened a new pull request, #3357:
URL: https://github.com/apache/bookkeeper/pull/3357

   ### Motivation
   
   There is a problem with the statistics of the journalCbQueueSize indicator. The incrementing position of the indicator is wrong, which will cause the indicator to be larger than the actual queue sizeļ¼š
   
   <img width="572" alt="image" src="https://user-images.githubusercontent.com/19296967/175611447-aebce84a-fdff-4505-83bb-fce321c9ed82.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1166188096

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1177273531

   I believe that we are already computing correctly this metric.
   
   when we add a entry we increment the values, and this means that there is a callback that is waiting to be executed.
   the time we keep the callback in this "queue" is from the addEntry to the time in which we execute the callback.
   
   with this change the value will be probably always zero, because you increment the value just before requesting the actual execution of the callback to the threadpool.
   
   I believe that it is a different metric.
   
   Also I believe that the docs are correct. Because we are not interested in the queue of the threadpool that executes the callback but in the "virtual queue" that handles the callbacks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1194411379

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 closed pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 closed pull request #3357: fix journalCbQueueSize compute
URL: https://github.com/apache/bookkeeper/pull/3357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zymap commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
zymap commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1194862198

   @lordcheng10 Do you have more progress on this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1173050308

   @eolivelli PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1166209019

   
   rerun failure checks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1175048228

   @hangc0276 PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1177379348

   > I believe that we are already computing correctly this metric.
   > 
   > 
   > 
   > when we add a entry we increment the values, and this means that there is a callback that is waiting to be executed.
   > 
   > the time we keep the callback in this "queue" is from the addEntry to the time in which we execute the callback.
   > 
   > 
   > 
   > with this change the value will be probably always zero, because you increment the value just before requesting the actual execution of the callback to the threadpool.
   > 
   > 
   > 
   > I believe that it is a different metric.
   > 
   > 
   > 
   > Also I believe that the docs are correct. Because we are not interested in the queue of the threadpool that executes the callback but in the "virtual queue" that handles the callbacks
   
   OK. I will add a new metric!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1177229609

   > the metric is the number of callbacks that are still to be executed. here you are incrementing the number before executing the callback, so you are changing the meaning of the metrics. your new metrics is the number of executing callbacks
   > 
   > if you need that number I suggest you to add a new metric
   
   <img width="535" alt="image" src="https://user-images.githubusercontent.com/19296967/177724253-2017ec66-eb1e-4405-8623-d3e22db4ebc3.png">
   
   The meaning of this indicator is described in the comments: The journal callback queue size.
   Or should I update the description?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1195081606

   > the metric is the number of callbacks that are still to be executed. here you are incrementing the number before executing the callback, so you are changing the meaning of the metrics. your new metrics is the number of executing callbacks
   > 
   > if you need that number I suggest you to add a new metric
   
   PTAL,thanks! @eolivelli @hangc0276 @StevenLuMT @zymap 
   I added a new metric cbThreadPoolQueueSize to count the queue size in the thread pool cbThreadPool:https://github.com/apache/bookkeeper/pull/3424  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1194964904

   @lordcheng10 Are you still working on it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1173050396

   @Shoothzj PTAL,thank!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1194412672

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1166188165

   @eolivelli @hangc0276 PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1171899963

   @hangc0276 PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1166209140

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1175667997

   @zymap PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1195030494

   > the metric is the number of callbacks that are still to be executed. here you are incrementing the number before executing the callback, so you are changing the meaning of the metrics. your new metrics is the number of executing callbacks
   > 
   > if you need that number I suggest you to add a new metric
   
   I will create a new metric to calculate the queue size. 
    I will close this PR.  @hangc0276 @zymap 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3357: fix journalCbQueueSize compute

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3357:
URL: https://github.com/apache/bookkeeper/pull/3357#issuecomment-1194412345

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org