You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2024/06/13 12:17:20 UTC
[PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
pitrou opened a new pull request, #42141:
URL: https://github.com/apache/arrow/pull/42141
### Rationale for this change
`parquet-encoding-benchmark` would make invalid memory accesses if more than one repetition per benchmark is requested by the user.
### What changes are included in this PR?
Make sure benchmark data initialization is idempotent.
### Are these changes tested?
Locally using Valgrind.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #42141:
URL: https://github.com/apache/arrow/pull/42141#issuecomment-2165491154
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42141:
URL: https://github.com/apache/arrow/pull/42141#issuecomment-2165496775
Revision: a8d11415f7168e93f69e0c58f9003356e1cb9746
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3d4611851b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3d4611851b)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478928/job/26180450933)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/9499479018/job/26180450969)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/9499479206/job/26180451751)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478867/job/26180450419)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478383/job/26180449258)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478504/job/26180449433)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478629/job/26180450289)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478981/job/26180450963)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/9499479661/job/26180452581)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478975/job/26180450944)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478874/job/26180450440)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/9499479216/job/26180451713)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478545/job/26180449775)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/9499479369/job/26180451998)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/9499479421/job/26180452386)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478401/job/26180449314)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/9499478370/job/26180449266)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/9499479111/job/26180451575)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #42141:
URL: https://github.com/apache/arrow/pull/42141#issuecomment-2165491513
@ursabot please benchmark lang=C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #42141:
URL: https://github.com/apache/arrow/pull/42141#issuecomment-2168761908
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit fc7b800a0ea38713391dd8772bb77583b6a56e6b.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/26251725830) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #42141:
URL: https://github.com/apache/arrow/pull/42141#issuecomment-2165491773
Benchmark runs are scheduled for commit a8d11415f7168e93f69e0c58f9003356e1cb9746. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #42141:
URL: https://github.com/apache/arrow/pull/42141#issuecomment-2166444962
Thanks for your patience. Conbench analyzed the 4 benchmarking runs that have been run so far on PR commit a8d11415f7168e93f69e0c58f9003356e1cb9746.
There were 9 benchmark results indicating a performance regression:
- Pull Request Run on `test-mac-arm` at [2024-06-13 16:10:14Z](https://conbench.ursa.dev/compare/runs/8ad969fb5b114da28765c27010e662d0...ad5facf5fde1424bba7152292e13acbe/)
- [`ArraySortIndicesStringNarrow` (C++) with params=65536/2, source=cpp-micro, suite=arrow-compute-vector-sort-benchmark](https://conbench.ursa.dev/compare/benchmarks/0666b01bc18b72f580008a249534352f...0666b1d8c17f72528000cc9a766a9a4f)
- [`ProjectionOverheadIsolated` (C++) with params=complex_expression/batch_size:1000/real_time, source=cpp-micro, suite=arrow-acero-project-benchmark](https://conbench.ursa.dev/compare/benchmarks/0666b01abde472e08000c4f7077b4ecc...0666b1d7bfa2772880005d182171f754)
- and 7 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/26197062677) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #42141:
URL: https://github.com/apache/arrow/pull/42141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-42140: [C++] Avoid invalid accesses in parquet-encoding-benchmark [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #42141:
URL: https://github.com/apache/arrow/pull/42141#issuecomment-2165702506
The CI failures are all unrelated. I'll still wait for benchmarking runs to finish to make sure they didn't fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org