You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/02/28 05:33:04 UTC
[jira] [Commented] (CB-8577) 'cordova plugin add --save'
should save variables into config.xml
[ https://issues.apache.org/jira/browse/CB-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341327#comment-14341327 ]
ASF GitHub Bot commented on CB-8577:
------------------------------------
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/174
CB-8577 BugFix 'cordova plugin add <plugin> --save' should properly save variables into config.xml to enable restoring later on.
CB-8577 BugFix 'cordova plugin add <plugin> --save' should properly save variables into config.xml to enable restoring later on.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-8577
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
----
commit 59b1a6bbbe89120281581cb4c9ced7f487c4e8fd
Author: Omar Mefire <om...@microsoft.com>
Date: 2015-02-28T04:30:27Z
CB-8577 BugFix 'cordova plugin add <plugin> --save' should properly save variables into config.xml to enable restoring later on.
----
> 'cordova plugin add <plugin> --save' should save variables into config.xml
> --------------------------------------------------------------------------
>
> Key: CB-8577
> URL: https://issues.apache.org/jira/browse/CB-8577
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Omar Mefire
>
> When adding a plugin with the --save/autosave option on, the variables (if any is passed) should be saved into config.xml so that the plugin can be auto-restored successfully later during 'prepare' or 'build' operation.
> For example:
> - cordova create hello com.omefire.hello Hello
> - cd hello
> - cordova plugin add com.phonegap.plugins.facebookconnect --variable APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in facebook plugin added to config.xml
> - cordova prepare android => results in an error message :
> " Installing "com.phonegap.plugins.facebookconnect" for android
> Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) missing: APP_ID, APP_NAME "
> This issue is due to the fact that 'cordova plugin add <plugin> --save' save variables in config.xml using the <param> tag instead of the <variable> tag.
> N.B: on 'cordova prepare <platform>', the plugins are restored from config.xml if they are not yet installed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org