You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by sandeep samudrala <sa...@gmail.com> on 2015/08/19 12:18:49 UTC
Review Request 37608: Update API throws NullPointerException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37608/
-----------------------------------------------------------
Review request for Falcon and Ajay Yadava.
Bugs: FALCON-1409
https://issues.apache.org/jira/browse/FALCON-1409
Repository: falcon-git
Description
-------
The response status from server needs to be checked for all actions in accordance with the changes during the update.
Diffs
-----
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java aa7fd0c
Diff: https://reviews.apache.org/r/37608/diff/
Testing
-------
I have tested it locally in distributed mode.
Thanks,
sandeep samudrala
Re: Review Request 37608: Update API throws NullPointerException
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37608/#review95849
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Aug. 19, 2015, 10:18 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37608/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 10:18 a.m.)
>
>
> Review request for Falcon and Ajay Yadava.
>
>
> Bugs: FALCON-1409
> https://issues.apache.org/jira/browse/FALCON-1409
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The response status from server needs to be checked for all actions in accordance with the changes during the update.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java aa7fd0c
>
> Diff: https://reviews.apache.org/r/37608/diff/
>
>
> Testing
> -------
>
> I have tested it locally in distributed mode.
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37608: Update API throws NullPointerException
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37608/#review95850
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java (line 314)
<https://reviews.apache.org/r/37608/#comment150996>
Instead of adding extra variable result , can we iterate the map and check whether all are succedded.
- pavan kumar kolamuri
On Aug. 19, 2015, 10:18 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37608/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 10:18 a.m.)
>
>
> Review request for Falcon and Ajay Yadava.
>
>
> Bugs: FALCON-1409
> https://issues.apache.org/jira/browse/FALCON-1409
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The response status from server needs to be checked for all actions in accordance with the changes during the update.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java aa7fd0c
>
> Diff: https://reviews.apache.org/r/37608/diff/
>
>
> Testing
> -------
>
> I have tested it locally in distributed mode.
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37608: Update API throws NullPointerException
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37608/#review95933
-----------------------------------------------------------
Ship it!
Ship It!
- pavan kumar kolamuri
On Aug. 20, 2015, 9:07 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37608/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2015, 9:07 a.m.)
>
>
> Review request for Falcon and Ajay Yadava.
>
>
> Bugs: FALCON-1409
> https://issues.apache.org/jira/browse/FALCON-1409
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The response status from server needs to be checked for all actions in accordance with the changes during the update.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java aa7fd0c
>
> Diff: https://reviews.apache.org/r/37608/diff/
>
>
> Testing
> -------
>
> I have tested it locally in distributed mode.
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 37608: Update API throws NullPointerException
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37608/
-----------------------------------------------------------
(Updated Aug. 20, 2015, 9:07 a.m.)
Review request for Falcon and Ajay Yadava.
Bugs: FALCON-1409
https://issues.apache.org/jira/browse/FALCON-1409
Repository: falcon-git
Description
-------
The response status from server needs to be checked for all actions in accordance with the changes during the update.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java aa7fd0c
Diff: https://reviews.apache.org/r/37608/diff/
Testing
-------
I have tested it locally in distributed mode.
Thanks,
sandeep samudrala