You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/19 03:02:45 UTC

[PR] chore(embedded-sdk): remove temporary OIDC diagnostic step [superset]

rusackas opened a new pull request, #41216:
URL: https://github.com/apache/superset/pull/41216

   ### SUMMARY
   
   Cleanup. The `Check OIDC availability` step was temporary scaffolding added while debugging why the **Embedded SDK Release** job couldn't authenticate via npm trusted publishing. The root cause turned out to be a Trusted Publisher config mismatch on npmjs.com (now corrected), and `@superset-ui/embedded-sdk@0.4.0` published successfully. This removes the diagnostic step now that it's served its purpose.
   
   The explanatory comment about intentionally omitting `registry-url` is **kept** on purpose — it guards against someone re-adding `registry-url`, which would re-introduce the `.npmrc` auth line that suppresses the OIDC exchange.
   
   No functional change to publishing.
   
   ### TESTING INSTRUCTIONS
   
   On the next push to `master`, *Embedded SDK Release* runs as before; the version-check script publishes only when the version is new, so it will no-op now that `0.4.0` is on npm.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] chore(embedded-sdk): remove temporary OIDC diagnostic step [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41216:
URL: https://github.com/apache/superset/pull/41216#issuecomment-4748127180

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] chore(embedded-sdk): remove temporary OIDC diagnostic step [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #41216:
URL: https://github.com/apache/superset/pull/41216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org